It seems keys have changed as well. In example: ABB: MICRO-0.25-I-OUTD-US-208 208V [CEC 2014], is now known as ABB: MICRO-0.25-I-OUTD-US-208 [208V]. So this change would not be backwards-compatible (i.e.: old code would need to be updated with the new keys).

@janinefreeman @cpaulgilman was the change in module/inverter name made by the CEC? Wondering if SAM maintained an association between old and new names for compatibilty.

How do you want to deal with that? Should I just change the keys in the tests and break backwards compatibility?

I think we can change the hardwired keys in the tests (there are maybe 5?) but we may have to fix the expected test outcomes. It would be good to learn that in thsi PR.

If so maybe we could take the chance and, at the same time, avoid replacing so many characters with _, as suggested by @wholmgren . Which is another backwards-incompatible change.

My view is to do the minimum work necessary to update to the new SAM files, given that we hope to work with NREL and others to build a more reliable and open system for developing and delivering the parameters. @wholmgren @mikofski

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions