8000 DIRINT and DIRINDEX discrepancies between 0.5.2 and 0.6.3 · Issue #738 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content
DIRINT and DIRINDEX discrepancies between 0.5.2 and 0.6.3 #738
Closed
@cedricleroy

Description

@cedricleroy

We are in the process of upgrading PVLib from v0.5.2 to v0.6.3, and caught some big changes in the DIRINT and DIRINDEX functions. Here are some plots ran from the same notebook with both versions:

0.5.2

image

image

image

image

0.6.3

The GHI clearsky (used by the DIRINDEX model) seems to be kind of shifted compared to 0.5.2:

image

image

image

DIRINT changed compared to 0.5.2 and DIRINDEX is way off:

image

Is this expected? Or are we doing anything wrong? It seems it is due to the changes in #400. Wanted to share this before digging further into the root cause.

Here is the notebook, and below are the data.

pvlib-data.csv.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0