`pvlib.soiling.hsu` takes `tilt` instead of `surface_tilt`

`pvlib.soiling.hsu` takes a `tilt` parameter representing the same thing we normally call `surface_tilt`:

https://github.com/pvlib/pvlib-python/blob/7a2ec9b4765124463bf0ddd0a49dcfedc4cbcad7/pvlib/soiling.py#L13-L14

https://github.com/pvlib/pvlib-python/blob/7a2ec9b4765124463bf0ddd0a49dcfedc4cbcad7/pvlib/soiling.py#L33-L34

I don't see any good reason for this naming inconsistency (I suspect `tilt` just got copied from the matlab implementation) and suggest we rename the parameter to `surface_tilt` with a deprecation.

Also, the docstring parameter type description says it must be `float`, but the model's reference explicitly says time series tilt is allowed: 

> The angle is variable for tracking systems and is taken as the average angle over the time step.



Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def hsu(rainfall, cleaning_threshold, tilt, pm2_5, pm10,
	depo_veloc=None, rain_accum_period=pd.Timedelta('1h')):

	tilt : float
	Tilt of the PV panels from horizontal. [degree]

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions