Closed
Description
Is your feature request related to a problem? Please describe.
When using pvlib.temperature.prilliman(), if the weather data does not include leap day (e.g., using 2020 PSM3 from pvlib.iotools.get_psm3() with the default leap_day=False), it returns:
NotImplementedError: algorithm does not yet support unequal times. consider resampling your data.
This could be a common scenario and could be confusing to the user.
Describe the solution you'd like
There are several possible solutions:
- Modify the error text to always say something like
NotImplementedError: algorithm does not yet support unequal times. consider resampling your data. check to make sure your data includes leap day for leap year(s). - Check to see if leap day is missing and tailor the error message accordingly (e.g., add
leap day is missing from your data.to the error message). - Check to see if leap day is missing, automatically fill it in somehow (e.g., repeat Feb 28), then remove it from the results before returning the output time series.
- Same as 3, but also notify the user that this has happened. Depending on time zone of the weather data, there might be a discontinuity in the resulting smoothed temperature after removing leap day (I think?).
Describe alternatives you've considered
Manually fill in leap day or repeat weather data query with leap day included (e.g., use leap_day=True with pvlib.iotools.get_psm3()).