8000 Merge pull request #155 from stonebig/master · psycow/winpython@18d78b6 · GitHub
[go: up one dir, main page]

Skip to content

Commit 18d78b6

Browse files
committed
Merge pull request winpython#155 from stonebig/master
qtconsole-4.0.1 removes this workaround need
2 parents 2c8ff91 + 129dee8 commit 18d78b6

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

make.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -551,14 +551,11 @@ def _create_launchers(self):
551551

552552

553553
if osp.isfile(osp.join(self.python_dir, 'Scripts', 'jupyter.exe')):
554-
#self.create_launcher('IPython Qt Console.exe', 'ipython.ico',
555-
# command='${WINPYDIR}\python.exe',
556-
# args='${WINPYDIR}\Scripts\jupyter-qtconsole',
557-
# workdir=r'${WINPYDIR}\..\notebooks')
558554
self.create_launcher('IPython Qt Console.exe', 'ipython.ico',
559-
command='$SYSDIR\cmd.exe',
560-
args=r'/k jupyter_start_qtconsole.bat',
561-
workdir=r'${WINPYDIR}\..\Scripts')
555+
command='${WINPYDIR}\Scripts\%s' %
556+
'jupyter-qtconsole.exe',
557+
workdir=r'${WINPYDIR}\..\notebooks')
558+
562559
self.create_launcher('Jupyter Notebook.exe', 'jupyter.ico',
563560
command='${WINPYDIR}\Scripts\%s' %
564561
'jupyter-notebook.exe',
@@ -687,14 +684,6 @@ def _create_batch_scripts(self):
687684
self.create_python_batch('pyqt5_demo.bat', 'qtdemo.pyw',
688685
workdir=r'Lib\site-packages\PyQt5\examples\qtdemo')
689686

690-
#workaround for Jupyter-qtconsole
691-
self.create_batch_script('jupyter_start_qtconsole.bat', r"""@echo off
692-
call %~dp0env.bat
693-
cd /D %WINPYDIR%\..\notebooks
694-
%WINPYDIR%\python.exe -c "from qtconsole.qtconsoleapp import main;main()"
695-
""")
696-
697-
698687

699688
# pre-run mingw batch
700689
print('now pre-running extra mingw')

0 commit comments

Comments
 (0)
0