8000 Fix issue where [xy]minorlocator=1 is not allowed (fixes #219) · proplot-dev/proplot@a5d0c44 · GitHub
[go: up one dir, main page]

Skip to content

Commit a5d0c44

Browse files
committed
Fix issue where [xy]minorlocator=1 is not allowed (fixes #219)
1 parent 31aca47 commit a5d0c44

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ ProPlot v0.7.0 (2021-06-30)
146146
rather than passing it to `colorbar()` (:commit:`a23e7043`).
147147
* Fix issue where axis is accidentally inverted for histogram plots (:issue:`191`).
148148
* Fix issue where numeric zero cannot be applied as legend label (:commit:`02417c8c`).
149+
* Fix issue where `minorlocator=1` is not allowed (:issue:`219`).
149150
* Fix issue where `~proplot.colors.Cycle` fails to register new names and fails to
150151
display in `~proplot.demos.show_cycles` (:commit:`94ffc1dc`, :commit:`4a7a3c79`).
151152
* Fix issue where proplot fails to detect legend entries for "outer"

proplot/axes/cartesian.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,7 @@ def format(
11171117
axis.set_major_locator(locator)
11181118
if isinstance(locator, mticker.IndexLocator):
11191119
tickminor = False # 'index' minor ticks make no sense
1120-
if minorlocator in (True, False):
1120+
if minorlocator is True or minorlocator is False: # must test identity
11211121
warnings._warn_proplot(
11221122
f'You passed {x}minorticks={minorlocator}, but this '
11231123
'argument is used to specify tick *locations*. If '

0 commit comments

Comments
 (0)
0