8000 Convert CI to CircleCI by SuperQ · Pull Request #592 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

Convert CI to CircleCI #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2020
Merged

Convert CI to CircleCI #592

merged 1 commit into from
Dec 27, 2020

Conversation

SuperQ
Copy link
Member
@SuperQ SuperQ commented Nov 5, 2020

Replace Travis with CircleCI.

  • Update Python version list.

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ SuperQ force-pushed the superq/circleci branch 2 times, most recently from a4283ae to 6c6b9ce Compare November 5, 2020 15:34
@brian-brazil
Copy link
Contributor

This doesn't seem to be doing quite the same thing. Some supported versions have been lost from testing, and we're no longer testing that things still work when none of the optional modules are installed.

@SuperQ
Copy link
Member Author
SuperQ commented Nov 5, 2020

Some of those old versions aren't supported by CircleCI (2.6, 3.4 for example).

@brian-brazil
Copy link
Contributor

There's a 3.4: https://hub.docker.com/layers/circleci/python/3.4/images/sha256-6403a42dff13d3593b541f75bb695584b5d6695675a4a1d1b2773081ede22e05?context=explore

It might be finally time to drop 2.6.

@SuperQ
Copy link
Member Author
SuperQ commented Nov 9, 2020

I was trying to go directly to CircleCI's "next gen" images.

@brian-brazil
Copy link
Contributor

If we're dropping versions, then setup.py needs updating.

@SuperQ SuperQ force-pushed the superq/circleci branch 5 times, most recently from 9a3c1e2 to 03b053a Compare December 27, 2020 15:19
@SuperQ
Convert CI to CircleCI
b939b06 
Replace Travis with CircleCI.
* Update Python version list.

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ
Copy link
Member Author
SuperQ commented Dec 27, 2020

I re-added Python 3.4 support.

@brian-brazil
Copy link
Contributor

👍

@SuperQ SuperQ merged commit f81891f into master Dec 27, 2020
@SuperQ SuperQ deleted the superq/circleci branch December 27, 2020 19:13
@csmarchbanks csmarchbanks mentioned this pull request Feb 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperQ @brian-brazil
0