10000 Fix py2.6 test · Issue #254 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

Fix py2.6 test #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smurfix opened this issue Mar 11, 2018 · 3 comments
Closed

Fix py2.6 test #254

smurfix opened this issue Mar 11, 2018 · 3 comments

Comments

@smurfix
Copy link
smurfix commented Mar 11, 2018

If you intend to keep #219 open, at least please fix the python2.6 test.

$ python3
Python 3.6.4+ (default, Feb 12 2018, 08:25:03) 
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.version
'3.6.4+ (default, Feb 12 2018, 08:25:03) \n[GCC 7.3.0]'
>>> 

  File "/src/home-assistant/homeassistant/components/prometheus.py", line 39, in setup
    import prometheus_client
  File "/src/home-assistant/.tox/py36/lib/python3.6/site-packages/prometheus_client/__init__.py", line 4, in <module>
    from . import exposition
  File "/src/home-assistant/.tox/py36/lib/python3.6/site-packages/prometheus_client/exposition.py", line 31, in <module>
    PYTHON26_OR_OLDER = tuple(int(val) for val in sys.version.split()[0].split('.')) < (2, 7, 0)
  File "/src/home-assistant/.tox/py36/lib/python3.6/site-packages/prometheus_client/exposition.py", line 31, in <genexpr>
    PYTHON26_OR_OLDER = tuple(int(val) for val in sys.version.split()[0].split('.')) < (2, 7, 0)
ValueError: invalid literal for int() with base 10: '4+'
@brian-brazil
Copy link
Contributor

Is this still happening with the latest version? I had thought this was fixed.

@hugovk
Copy link
Contributor
hugovk commented May 5, 2018

This was fixed in PR #227, merged on 19 Dec 2017.

@brian-brazil
Copy link
Contributor

Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smurfix @hugovk @brian-brazil
0