8000 Fix order-dependent flaky tests related to UTF-8 support · prometheus/client_python@eee9fc0 · GitHub
[go: up one dir, main page]

Skip to content

Commit eee9fc0

Browse files
committed
Fix order-dependent flaky tests related to UTF-8 support
Signed-off-by: Dennis Gaebler <dennis.gaebler@uni-ulm.de>
1 parent 46eae7b commit eee9fc0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/test_core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,9 +513,9 @@ def test_exemplar_invalid_legacy_label_name(self):
513513
enable_legacy_validation()
514514
self.assertRaises(ValueError, self.histogram.observe, 3.0, exemplar={':o)': 'smile'})
515515
self.assertRaises(ValueError, self.histogram.observe, 3.0, exemplar={'1': 'number'})
516+
disable_legacy_validation()
516517

517518
def test_exemplar_invalid_label_name(self):
518-
disable_legacy_validation()
519519
self.histogram.observe(3.0, exemplar={':o)': 'smile'})
520520
self.histogram.observe(3.0, exemplar={'1': 'number'})
521521

@@ -669,9 +669,9 @@ def test_invalid_legacy_names_raise(self):
669669
self.assertRaises(ValueError, Counter, 'c_total', '', labelnames=['a:b'])
670670
self.assertRaises(ValueError, Counter, 'c_total', '', labelnames=['__reserved'])
671671
self.assertRaises(ValueError, Summary, 'c_total', '', labelnames=['quantile'])
672+
disable_legacy_validation()
672673

673674
def test_invalid_names_raise(self):
674-
disable_legacy_validation()
675675
self.assertRaises(ValueError, Counter, '', 'help')
676676
self.assertRaises(ValueError, Counter, '', 'help', namespace='&')
677677
self.assertRaises(ValueError, Counter, '', 'help', subsystem='(')

0 commit comments

Comments
 (0)
0