Support two or three element tuples in HistogramMetricFamily

csmarchbanks · csmarchbanks · commit b3a00ea9aabd · 2022-02-10T14:00:20.000-07:00
Signed-off-by: Chris Marchbanks &lt;csmarchbanks@gmail.com&gt;
diff --git a/prometheus_client/metrics_core.py b/prometheus_client/metrics_core.py
@@ -232,7 +232,7 @@ class HistogramMetricFamily(Metric):
     def __init__(self,
                  name: str,
                  documentation: str,
-                 buckets: Optional[Sequence[Tuple[str, float, Optional[Exemplar]]]] = None,
+                 buckets: Optional[Sequence[Union[Tuple[str, float], Tuple[str, float, Exemplar]]]] = None,
                  sum_value: Optional[Union[int, float]] = None,
                  labels: Optional[Sequence[str]] = None,
                  unit: str = '',
@@ -250,7 +250,7 @@ def __init__(self,
 
     def add_metric(self,
                    labels: Sequence[str],
-                   buckets: Sequence[Tuple[str, float, Optional[Exemplar]]],
+                   buckets: Sequence[Union[Tuple[str, float], Tuple[str, float, Exemplar]]],
                    sum_value: Optional[Union[int, float]],
                    timestamp: Optional[Union[Timestamp, float]] = None) -> None:
         """Add a metric to the metric family.
@@ -267,7 +267,7 @@ def add_metric(self,
             bucket, value = b[:2]
             exemplar = None
             if len(b) == 3:
-                exemplar = b[2]
+                exemplar = b[2]  # type: ignore
             self.samples.append(Sample(
                 self.name + '_bucket',
                 dict(list(zip(self._labelnames, labels)) + [('le', bucket)]),
