Comment on memory leak #340

sbrandtb · sbrandtb · commit 51de8badc929 · 2018-12-11T09:27:40.000+01:00
Signed-off-by: Sebastian Brandt &lt;sebastian.brandt@friday.de&gt;
diff --git a/prometheus_client/exposition.py b/prometheus_client/exposition.py
@@ -173,6 +173,11 @@ def factory(cls, registry):
 
 class _ThreadingSimpleServer(ThreadingMixIn, HTTPServer):
     """Thread per request HTTP server."""
+    # Make worker threads "fire and forget". Beginning with Python 3.7 this
+    # prevents a memory leak because ``ThreadingMixIn`` starts to gather all
+    # non-daemon threads in a list in order to join on them at server close.
+    # Enabling daemon threads virtually makes ``_ThreadingSimpleServer`` the
+    # same as Python 3.7's ``ThreadingHTTPServer``.
     daemon_threads = True
 
 
