Switch to n4-highpcu-4 instances for Felix FVs #11578
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats report consistently low RAM usage on the tst runners, so this should save some cost.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes CI costs by switching Felix FV test execution from n4-standard-4 to n4-highcpu-4 GCP instance types, based on observed low RAM usage patterns in the test runners.
- Introduces VM_MACHINE_TYPE environment variable for configurable instance types
- Adds documentation explaining the choice of 4 vCPUs and high-CPU machine type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| felix/.semaphore/fv-prologue | Exports VM_MACHINE_TYPE=n4-highcpu-4 with explanatory comments about vCPU requirements and RAM usage patterns |
| .semaphore/vms/create-test-vms | Updates gcloud instance creation to use configurable machine_type variable with n4-standard-4 as default for backward compatibility |
Member
Author
|
Wow, I hit OOMs with this. One or two tests use lots of RAM, not sure why (perhaps gratuitous logging to a memory buffer?) |
Member
Author
|
Looks like the QoS tests slurp up 4GB of BPF logs when they run at debug 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stats report consistently low RAM usage on the tst runners, so this should save some cost.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.