8000 Introduce durable_rename() and durable_link_or_rename(). · prmdeveloper/postgres@63b06e8 · GitHub
[go: up one dir, main page]
Skip to content

Commit 63b06e8

Browse files
anarazelanarazel
committed
Introduce durable_rename() and durable_link_or_rename().
Renaming a file using rename(2) is not guaranteed to be durable in face of crashes; especially on filesystems like xfs and ext4 when mounted with data=writeback. To be certain that a rename() atomically replaces the previous file contents in the face of crashes and different filesystems, one has to fsync the old filename, rename the file, fsync the new filename, fsync the containing directory. This sequence is not generally adhered to currently; which exposes us to data loss risks. To avoid having to repeat this arduous sequence, introduce durable_rename(), which wraps all that. Also add durable_link_or_rename(). Several places use link() (with a fallback to rename()) to rename a file, trying to avoid replacing the target file out of paranoia. Some of those rename sequences need to be durable as well. There seems little reason extend several copies of the same logic, so centralize the link() callers. This commit does not yet make use of the new functions; they're used in a followup commit. Author: Michael Paquier, Andres Freund Discussion: 56583BDD.9060302@2ndquadrant.com Backpatch: All supported branches
1 parent b2ce948 commit 63b06e8

File tree

5 files changed

+215
-52
lines changed

5 files changed

+215
-52
lines changed

‎src/backend/replication/logical/origin.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ CheckPointReplicationOrigin(void)
625625
tmppath, path)));
626626
}
627627

628-
fsync_fname((char *) path, false);
628+
fsync_fname(path, false);
629629
fsync_fname("pg_logical", true);
630630
}
631631

‎src/backend/replication/slot.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ SaveSlotToPath(ReplicationSlot *slot, const char *dir, int elevel)
10441044
START_CRIT_SECTION();
10451045

10461046
fsync_fname(path, false);
1047-
fsync_fname((char *) dir, true);
1047+
fsync_fname(dir, true);
10481048
fsync_fname("pg_replslot", true);
10491049

10501050
END_CRIT_SECTION();

‎src/backend/storage/file/fd.c

Lines changed: 209 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,10 @@ static void walkdir(const char *path,
306306
#ifdef PG_FLUSH_DATA_WORKS
307307
static void pre_sync_fname(const char *fname, bool isdir, int elevel);
308308
#endif
309-
static void fsync_fname_ext(const char *fname, bool isdir, int elevel);
309+
static void datadir_fsync_fname(const char *fname, bool isdir, int elevel);
310+
311+
static int fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel);
312+
static int fsync_parent_path(const char *fname, int elevel);
310313

311314

312315
/*
@@ -413,54 +416,158 @@ pg_flush_data(int fd, off_t offset, off_t amount)
413416
* indicate the OS just doesn't allow/require fsyncing directories.
414417
*/
415418
void
416-
fsync_fname(char *fname, bool isdir)
419+
fsync_fname(const char *fname, bool isdir)
420+
{
421+
fsync_fname_ext(fname, isdir, false, ERROR);
422+
}
423+
424+
/*
425+
* durable_rename -- rename(2) wrapper, issuing fsyncs required for durability
426+
*
427+
* This routine ensures that, after returning, the effect of renaming file
428+
* persists in case of a crash. A crash while this routine is running will
429+
* leave you with either the pre-existing or the moved file in place of the
430+
* new file; no mixed state or truncated files are possible.
431+
*
432+
* It does so by using fsync on the old filename and the possibly existing
433+
* target filename before the rename, and the target file and directory after.
434+
*
435+
* Note that rename() cannot be used across arbitrary directories, as they
436+
* might not be on the same filesystem. Therefore this routine does not
437+
* support renaming across directories.
438+
*
439+
* Log errors with the caller specified severity.
440+
*
441+
* Returns 0 if the operation succeeded, -1 otherwise. Note that errno is not
442+
* valid upon return.
443+
*/
444+
int
445+
durable_rename(const char *oldfile, const char *newfile, int elevel)
417446
{
418447
int fd;
419-
int returncode;
420448

421449
/*
422-
* Some OSs require directories to be opened read-only whereas other
423-
* systems don't allow us to fsync files opened read-only; so we need both
424-
* cases here
450+
* First fsync the old and target path (if it exists), to ensure that they
451+
* are properly persistent on disk. Syncing the target file is not
452+
* strictly necessary, but it makes it easier to reason about crashes;
453+
* because it's then guaranteed that either source or target file exists
454+
* after a crash.
425455
*/
426-
if (!isdir)
427-
fd = OpenTransientFile(fname,
428-
O_RDWR | PG_BINARY,
429-
S_IRUSR | S_IWUSR);
456+
if (fsync_fname_ext(oldfile, false, false, elevel) != 0)
457+
return -1;
458+
459+
fd = OpenTransientFile((char *) newfile, PG_BINARY | O_RDWR, 0);
460+
if (fd < 0)
461+
{
462+
if (errno != ENOENT)
463+
{
464+
ereport(elevel,
465+
(errcode_for_file_access(),
466+
errmsg("could not open file \"%s\": %m", newfile)));
467+
return -1;
468+
}
469+
}
430470
else
431-
fd = OpenTransientFile(fname,
432-
O_RDONLY | PG_BINARY,
433-
S_IRUSR | S_IWUSR);
471+
{
472+
if (pg_fsync(fd) != 0)
473+
{
474+
int save_errno;
475+
476+
/* close file upon error, might not be in transaction context */
477+
save_errno = errno;
478+
CloseTransientFile(fd);
479+
errno = save_errno;
480+
481+
ereport(elevel,
482+
(errcode_for_file_access(),
483+
errmsg("could not fsync file \"%s\": %m", newfile)));
484+
return -1;
485+
}
486+
CloseTransientFile(fd);
487+
}
488+
489+
/* Time to do the real deal... */
490+
if (rename(oldfile, newfile) < 0)
491+
{
492+
ereport(elevel,
493+
(errcode_for_file_access(),
494+
errmsg("could not rename file \"%s\" to \"%s\": %m",
495+
oldfile, newfile)));
496+
return -1;
497+
}
434498

435499
/*
436-
* Some OSs don't allow us to open directories at all (Windows returns
437-
* EACCES)
500+
* To guarantee renaming the file is persistent, fsync the file with its
501+
* new name, and its containing directory.
438502
*/
439-
if (fd < 0 && isdir && (errno == EISDIR || errno == EACCES))
440-
return;
503+
if (fsync_fname_ext(newfile, false, false, elevel) != 0)
504+
return -1;
441505

442-
else if (fd < 0)
443-
ereport(ERROR,
444-
(errcode_for_file_access(),
445-
errmsg("could not open file \"%s\": %m", fname)));
506+
if (fsync_parent_path(newfile, elevel) != 0)
507+
return -1;
446508

447-
returncode = pg_fsync(fd);
509+
return 0;
510+
}
511+
512+
/*
513+
* durable_link_or_rename -- rename a file in a durable manner.
514+
*
515+
* Similar to durable_rename(), except that this routine tries (but does not
516+
* guarantee) not to overwrite the target file.
517+
*
518+
* Note that a crash in an unfortunate moment can leave you with two links to
519+
* the target file.
520+
*
521+
* Log errors with the caller specified severity.
522+
*
523+
* Returns 0 if the operation succeeded, -1 otherwise. Note that errno is not
524+
* valid upon return.
525+
*/
526+
int
527+
durable_link_or_rename(const char *oldfile, const char *newfile, int elevel)
528+
{
529+
/*
530+
* Ensure that, if we crash directly after the rename/link, a file with
531+
* valid contents is moved into place.
532+
*/
533+
if (fsync_fname_ext(oldfile, false, false, elevel) != 0)
534+
return -1;
448535

449-
/* Some OSs don't allow us to fsync directories at all */
450-
if (returncode != 0 && isdir && errno == EBADF)
536+
#if HAVE_WORKING_LINK
537+
if (link(oldfile, newfile) < 0)
451538
{
452-
CloseTransientFile(fd);
453-
return;
539+
ereport(elevel,
540+
(errcode_for_file_access(),
541+
errmsg("could not link file \"%s\" to \"%s\": %m",
542+
oldfile, newfile)));
543+
return -1;
454544
}
455-
456-
if (returncode != 0)
457-
ereport(ERROR,
545+
unlink(oldfile);
546+
#else
547+
/* XXX: Add racy file existence check? */
548+
if (rename(oldfile, newfile) < 0)
549+
{
550+
ereport(elevel,
458551
(errcode_for_file_access(),
459-
errmsg("could not fsync file \"%s\": %m", fname)));
552+
errmsg("could not rename file \"%s\" to \"%s\": %m",
553+
oldfile, newfile)));
554+
return -1;
555+
}
556+
#endif
460557

461-
CloseTransientFile(fd);
462-
}
558+
/*
559+
* Make change persistent in case of an OS crash, both the new entry and
560+
* its parent directory need to be flushed.
561+
*/
562+
if (fsync_fname_ext(newfile, false, false, elevel) != 0)
563+
return -1;
564+
565+
/* Same for parent directory */
566+
if (fsync_parent_path(newfile, elevel) != 0)
567+
return -1;
463568

569+
return 0;
570+
}
464571

465572
/*
466573
* InitFileAccess --- initialize this module during backend startup
@@ -2547,10 +2654,10 @@ SyncDataDirectory(void)
25472654
* in pg_tblspc, they'll get fsync'd twice. That's not an expected case
25482655
* so we don't worry about optimizing it.
25492656
*/
2550-
walkdir(".", fsync_fname_ext, false, LOG);
2657+
walkdir(".", datadir_fsync_fname, false, LOG);
25512658
if (xlog_is_symlink)
2552-
walkdir("pg_xlog", fsync_fname_ext, false, LOG);
2553-
walkdir("pg_tblspc", fsync_fname_ext, true, LOG);
2659+
walkdir("pg_xlog", datadir_fsync_fname, false, LOG);
2660+
walkdir("pg_tblspc", datadir_fsync_fname, true, LOG);
25542661
}
25552662

25562663
/*
@@ -2664,15 +2771,26 @@ pre_sync_fname(const char *fname, bool isdir, int elevel)
26642771

26652772
#endif /* PG_FLUSH_DATA_WORKS */
26662773

2774+
static void
2775+
datadir_fsync_fname(const char *fname, bool isdir, int elevel)
2776+
{
2777+
/*
2778+
* We want to silently ignoring errors about unreadable files. Pass that
2779+
* desire on to fsync_fname_ext().
2780+
*/
2781+
fsync_fname_ext(fname, isdir, true, elevel);
2782+
}
2783+
26672784
/*
26682785
* fsync_fname_ext -- Try to fsync a file or directory
26692786
*
2670-
* Ignores errors trying to open unreadable files, or trying to fsync
2671-
* directories on systems where that isn't allowed/required, and logs other
2672-
* errors at a caller-specified level.
2787+
* If ignore_perm is true, ignore errors upon trying to open unreadable
2788+
* files. Logs other errors at a caller-specified level.
2789+
*
2790+
* Returns 0 if the operation succeeded, -1 otherwise.
26732791
*/
2674-
static void
2675-
fsync_fname_ext(const char *fname, bool isdir, int elevel)
2792+
static int
2793+
fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)
26762794
{
26772795
int fd;
26782796
int flags;
@@ -2690,20 +2808,23 @@ fsync_fname_ext(const char *fname, bool isdir, int elevel)
26902808
else
26912809
flags |= O_RDONLY;
26922810

2811+
fd = OpenTransientFile((char *) fname, flags, 0);
2812+
26932813
/*
2694-
* Open the file, silently ignoring errors about unreadable files (or
2695-
* unsupported operations, e.g. opening a directory under Windows), and
2696-
* logging others.
2814+
* Some OSs don't allow us to open directories at all (Windows returns
2815+
* EACCES), just ignore the error in that case. If desired also silently
2816+
* ignoring errors about unreadable files. Log others.
26972817
*/
2698-
fd = OpenTransientFile((char *) fname, flags, 0);
2699-
if (fd < 0)
2818+
if (fd < 0 && isdir && (errno == EISDIR || errno == EACCES))
2819+
return 0;
2820+
else if (fd < 0 && ignore_perm && errno == EACCES)
2821+
return 0;
2822+
else if (fd < 0)
27002823
{
2701-
if (errno == EACCES || (isdir && errno == EISDIR))
2702-
return;
27032824
ereport(elevel,
27042825
(errcode_for_file_access(),
27052826
errmsg("could not open file \"%s\": %m", fname)));
2706-
return;
2827+
return -1;
27072828
}
27082829

27092830
returncode = pg_fsync(fd);
@@ -2713,9 +2834,49 @@ fsync_fname_ext(const char *fname, bool isdir, int elevel)
27132834
* those errors. Anything else needs to be logged.
27142835
*/
27152836
if (returncode != 0 && !(isdir && errno == EBADF))
2837+
{
2838+
int save_errno;
2839+
2840+
/* close file upon error, might not be in transaction context */
2841+
save_errno = errno;
2842+
(void) CloseTransientFile(fd);
2843+
errno = save_errno;
2844+
27162845
ereport(elevel,
27172846
(errcode_for_file_access(),
27182847
errmsg("could not fsync file \"%s\": %m", fname)));
2848+
return -1;
2849+
}
27192850

27202851
(void) CloseTransientFile(fd);
2852+
2853+
return 0;
2854+
}
2855+
2856+
/*
2857+
* fsync_parent_path -- fsync the parent path of a file or directory
2858+
*
2859+
* This is aimed at making file operations persistent on disk in case of
2860+
* an OS crash or power failure.
2861+
*/
2862+
static int
2863+
fsync_parent_path(const char *fname, int elevel)
2864+
{
2865+
char parentpath[MAXPGPATH];
2866+
2867+
strlcpy(parentpath, fname, MAXPGPATH);
2868+
get_parent_directory(parentpath);
2869+
2870+
/*
2871+
* get_parent_directory() returns an empty string if the input argument is
2872+
* just a file name (see comments in path.c), so handle that as being the
2873+
* current directory.
2874+
*/
2875+
if (strlen(parentpath) == 0)
2876+
strlcpy(parentpath, ".", MAXPGPATH);
2877+
2878+
if (fsync_fname_ext(parentpath, true, false, elevel) != 0)
2879+
return -1;
2880+
2881+
return 0;
27212882
}

‎src/backend/storage/file/reinit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ ResetUnloggedRelationsInDbspaceDir(const char *dbspacedirname, int op)
385385

386386
FreeDir(dbspace_dir);
387387

388-
fsync_fname((char *) dbspacedirname, true);
388+
fsync_fname(dbspacedirname, true);
389389
}
390390
}
391391

‎src/include/storage/fd.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ extern int pg_fsync_no_writethrough(int fd);
113113
extern int pg_fsync_writethrough(int fd);
114114
extern int pg_fdatasync(int fd);
115115
extern int pg_flush_data(int fd, off_t offset, off_t amount);
116-
extern void fsync_fname(char *fname, bool isdir);
116+
extern void fsync_fname(const char *fname, bool isdir);
117+
extern int durable_rename(const char *oldfile, const char *newfile, int loglevel);
118+
extern int durable_link_or_rename(const char *oldfile, const char *newfile, int loglevel);
117119
extern void SyncDataDirectory(void);
118120

119121
/* Filename components for OpenTemporaryFile */

0 commit comments

Comments
 (0)
0