-
Notifications
You must be signed in to change notification settings - Fork 84
Feature/source git #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/source git #137
Conversation
@@ -129,8 +132,84 @@ async fn url_src( | |||
Ok(cache_name) | |||
} | |||
|
|||
fn git_src(_source: &GitSrc) { | |||
todo!("Git source support not implemented yet!"); | |||
/// Fetch the repo and its specific refspecs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document how it works with the src_cache
dir?
I think cloning with depth is still a bit out: libgit2/libgit2#6396 In general, I am wondering if we should use
On the other hand, using
Regardless, I'm happy to merge this PR once we have a little more documentation (I would like to understand how / if the source_cache works with git repositories). |
@wolfv I'm also not sure. I continued this direction to hopefully avoid OS-specific differences in the cli. Plus the error handling is probably easier as now you just have everything in rust. But I get what you saying. I could try to redo it in another branch to see if that would work better. |
I think cargo is also originally using However, I read somewhere that |
The cargo use case is a little bit different from ours -- packages that are git-able with cargo are usually also very compatible with cargo (since they are cargo packages as well) while we might have to deal with clunky C++ behemoth repos from the before times :) |
Add git as a source for the package building as specified here
What is still missing is
git-lfs
integration andgit_depth
cloning.