-
Notifications
You must be signed in to change notification settings - Fork 4
Description
I know there is no explicit dependency management for script or system hooks or local repos. This is not a problem when used locally, because people could install the dependencies once. However, there is no way to install these dependencies for https://pre-commit.ci to my knowledge. This means that any pre-commit.ci reun will fail if it has at least one local, system or script hook if I am not mistaken. An example is this run.
I saw there is #11 which would provide maximum flexibility. Maybe there is also a way to limit the scope and run custom code only before the hook check?
If not, maybe it would be helpful to indicate in .pre-commit-config.yaml if a hook should run on pre-commit.ci. Or set an env variable that can be checked in a system, script or local hook.
Looking forward for this to reach production readiness 🥳
cc: @katrinleinweber. Maybe we should anyways aim to support R as a language, as discussed in pre-commit/pre-commit#926. There is support for conda now, maybe we can follow the PR and use renv: pre-commit/pre-commit#1232. If you are interested, let's discuss in lorenzwalthert/precommit#215. In any case, this would not solve the problem for local hooks and system or script hook in general.