8000 Fix: Flutter 2.5.0 `RTCVideoRendererWeb` bug (#681) · prashantspandey/flutter-webrtc@7b0124e · GitHub
[go: up one dir, main page]
Skip to content

Commit 7b0124e

Browse files
hiroshihoriehiroshihorie
authored
Fix: Flutter 2.5.0 RTCVideoRendererWeb bug (flutter-webrtc#681)
* Use `track` instead of `kind` when both `track` and `kind` are set (flutter-webrtc#4) * `getSettings` for Web (flutter-webrtc#3) * Fix: init would never be `RTCRtpTransceiverInitWeb` * Clean up * Fix: Flutter 2.5.0 `RTCVideoRendererWeb` bug
< 8000 div class="d-flex flex-items-center flex-wrap fgColor-muted gap-1">
1 parent 87ca206 commit 7b0124e

8 files changed

+10
-20
lines changed

‎lib/src/helper.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/foundation.dart';
22
import 'package:flutter/services.dart';
33

4-
import 'package:flutter_webrtc/flutter_webrtc.dart';
4+
import '../flutter_webrtc.dart';
55
import 'interface/media_stream.dart';
66
import 'interface/mediadevices.dart';
77

‎lib/src/interface/media_stream_track.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'dart:typed_data';
22

3-
import 'package:flutter_webrtc/src/helper.dart';
3+
import '../helper.dart';
44

55
typedef StreamTrackCallback = Function();
66

‎lib/src/native/media_stream_track_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'dart:typed_data';
44

55
import 'package:path_provider/path_provider.dart';
66

7-
import 'package:flutter_webrtc/flutter_webrtc.dart';
7+
import '../helper.dart';
88
import '../interface/media_stream_track.dart';
99
import 'utils.dart';
1010

‎lib/src/native/rtc_video_renderer_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'dart:async';
22

33
import 'package:flutter/services.dart';
44

5-
import 'package:flutter_webrtc/flutter_webrtc.dart';
5+
import '../helper.dart';
66
import '../interface/media_stream.dart';
77
import '../interface/rtc_video_renderer.dart';
88
import 'utils.dart';

‎lib/src/web/rtc_peerconnection_impl.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import 'dart:html' as html;
33
import 'dart:js' as js;
44
import 'dart:js_util' as jsutil;
55

6-
import 'package:flutter_webrtc/src/interface/rtc_track_event.dart';
7-
import 'package:flutter_webrtc/src/web/rtc_rtp_transceiver_impl.dart';
86
import '../interface/enums.dart';
97
import '../interface/media_stream.dart';
108
import '../interface/media_stream_track.dart';
@@ -17,12 +15,14 @@ import '../interface/rtc_rtp_sender.dart';
1715
import '../interface/rtc_rtp_transceiver.dart';
1816
import '../interface/rtc_session_description.dart';
1917
import '../interface/rtc_stats_report.dart';
18+
import '../interface/rtc_track_event.dart';
2019
import 'media_stream_impl.dart';
2120
import 'media_stream_track_impl.dart';
2221
import 'rtc_data_channel_impl.dart';
2322
import 'rtc_dtmf_sender_impl.dart';
2423
import 'rtc_rtp_receiver_impl.dart';
2524
import 'rtc_rtp_sender_impl.dart';
25+
import 'rtc_rtp_transceiver_impl.dart';
2626

2727
/*
2828
* PeerConnection

‎lib/src/web/rtc_rtp_sender_impl.dart

< 8000 span aria-hidden="true" class="f6 text-bold fgColor-danger">-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import 'dart:js_util' as jsutil;
44

55
import 'package:flutter/services.dart';
66

7-
import 'package:flutter_webrtc/flutter_webrtc.dart';
87
import '../interface/media_stream_track.dart';
98
import '../interface/rtc_dtmf_sender.dart';
109
import '../interface/rtc_rtp_parameters.dart';
1110
import '../interface/rtc_rtp_sender.dart';
11+
import '../interface/rtc_stats_report.dart';
1212
import 'media_stream_track_impl.dart';
1313
import 'rtc_dtmf_sender_impl.dart';
1414
import 'rtc_rtp_parameters_impl.dart';

‎lib/src/web/rtc_rtp_transceiver_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ import 'dart:js_util' as jsutil;
33

44
import 'package:flutter/services.dart';
55

< 67E6 code>6-
import 'package:flutter_webrtc/src/web/media_stream_impl.dart';
76
import '../interface/enums.dart';
87
import '../interface/media_stream.dart';
98
import '../interface/rtc_rtp_parameters.dart';
109
import '../interface/rtc_rtp_receiver.dart';
1110
import '../interface/rtc_rtp_sender.dart';
1211
import '../interface/rtc_rtp_transceiver.dart';
12+
import 'media_stream_impl.dart';
1313
import 'rtc_rtp_receiver_impl.dart';
1414
import 'rtc_rtp_sender_impl.dart';
1515

‎lib/src/web/rtc_video_renderer_impl.dart

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,8 @@ class RTCVideoRendererWeb extends VideoRenderer {
154154
}
155155

156156
html.VideoElement? findHtmlView() {
157-
final video = html.document.getElementById(_elementIdForVideo);
158-
if (null != video) return video as html.VideoElement;
159-
160-
final fltPv = html.document.getElementsByTagName('flt-platform-view');
161-
if (fltPv.isEmpty) return null;
162-
final child = (fltPv.first as html.Element).shadowRoot!.childNodes;
163-
for (final item in child) {
164-
if ((item as html.Element).id == _elementIdForVideo) {
165-
return item as html.VideoElement;
166-
}
167-
}
168-
return null;
157+
final element = html.document.getElementById(_elementIdForVideo);
158+
if (null != element) return element as html.VideoElement;
169159
}
170160

171161
@override

0 commit comments

Comments
 (0)
0