book2: fix frozen string literal problem

peff · peff · commit dc247743a345 · 2023-03-16T10:08:28.000-04:00
Book generation has been broken since 6a1d3bc (freeze string literals in rake tasks, 2022-10-05). The issue is the use of force_encoding() on a literal, which doesn't work if it's frozen. One solution would be to just .dup the literal. However, this force_encoding is not necessary at all these days. Since ruby 2.0, strings are UTF8 by default. So we can just get rid of it.
diff --git a/lib/tasks/book2.rake b/lib/tasks/book2.rake
@@ -13,7 +13,7 @@ def expand(content, path, &get_content)
     end
     new_content = get_content.call(new_fname)
     if new_content
-      expand(new_content.gsub("\xEF\xBB\xBF".force_encoding("UTF-8"), ""), new_fname) { |c| get_content.call(c) }
+      expand(new_content.gsub("\xEF\xBB\xBF", ""), new_fname) { |c| get_content.call(c) }
     else
       puts "#{new_fname} could not be resolved for expansion"
       ""
