8000 Generalize join() · powercoder23/immutable-js@965d08c · GitHub
[go: up one dir, main page]

Skip to content

Commit 965d08c

Browse files
committed
Generalize join()
1 parent 8d7bca7 commit 965d08c

File tree

3 files changed

+22
-47
lines changed

3 files changed

+22
-47
lines changed

dist/Immutable.js

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -251,17 +251,13 @@ var $Sequence = Sequence;
251251
},
252252
join: function(separator) {
253253
separator = separator !== undefined ? '' + separator : ',';
254-
var string = '';
254+
var joined = '';
255255
var isFirst = true;
256-
this.forEach((function(v, k) {
257-
if (isFirst) {
258-
isFirst = false;
259-
string += (v != null ? v : '');
260-
} else {
261-
string += separator + (v != null ? D074 v : '');
262-
}
256+
this.forEach((function(v) {
257+
isFirst ? (isFirst = false) : (joined += separator);
258+
joined += v != null ? v : '';
263259
}));
264-
return string;
260+
return joined;
265261
},
266262
count: function(predicate, thisArg) {
267263
if (!predicate) {
@@ -633,14 +629,6 @@ var $IndexedSequence = IndexedSequence;
633629
};
634630
return fromEntriesSequence;
635631
},
636-
join: function(separator) {
637-
separator = separator !== undefined ? '' + separator : ',';
638-
var joined = '';
639-
this.forEach((function(v, ii) {
640-
joined += (ii ? separator : '') + (v != null ? v : '');
641-
}));
642-
return joined;
643-
},
644632
concat: function() {
645633
for (var values = [],
646634
$__3 = 0; $__3 < arguments.length; $__3++)

0 commit comments

Comments
 (0)
0