[#274] Unused should_rm_dirs is deleted (cleanup) (#275)

dmitry-lipetsk · web-flow · commit d6be913a79b9 · 2025-06-26T22:13:42.000+03:00
This strange PostgresNode property is not documented and is not used in Testgres code.
diff --git a/testgres/backup.py b/testgres/backup.py
@@ -163,10 +163,6 @@ def spawn_primary(self, name=None, destroy=True):
         assert type(node) == self.original_node.__class__  # noqa: E721
 
         with clean_on_error(node) as node:
-
-            # New nodes should always remove dir tree
-            node._should_rm_dirs = True
-
             # Set a new port
             node.append_conf(filename=PG_CONF_FILE, line='\n')
             node.append_conf(filename=PG_CONF_FILE, port=node.port)
diff --git a/testgres/node.py b/testgres/node.py
@@ -2384,7 +2384,6 @@ def make_empty(
         self.os_ops.makedirs(real_base_dir)
 
         node = PostgresNode(base_dir=real_base_dir, port=port, bin_dir=bin_dir)
-        node.should_rm_dirs = True
         self.nodes_to_cleanup.append(node)
 
         return node
