NodeApp::make_simple is corrected (bad assert)

dmitry-lipetsk · dmitry-lipetsk · commit d5c367203460 · 2025-06-27T21:17:48.000+03:00
when checksum == True and initdb_params contains "--data-checksums", "assert final_initdb_params is not initdb_params" raised.
diff --git a/testgres/node_app.py b/testgres/node_app.py
@@ -112,7 +112,6 @@ def make_simple(
                 final_initdb_params,
                 '--data-checksums'
             )
-            assert final_initdb_params is not initdb_params
             assert final_initdb_params is not None
             assert '--data-checksums' in final_initdb_params
 
diff --git a/tests/test_testgres_common.py b/tests/test_testgres_common.py
@@ -1717,6 +1717,11 @@ def LOCAL__test(checksum: bool, initdb_params: typing.Optional[list]):
         LOCAL__test(checksum=False, initdb_params=params)
         LOCAL__test(checksum=True, initdb_params=params)
 
+        # -----------
+        params = ["--data-checksums"]
+        LOCAL__test(checksum=False, initdb_params=params)
+        LOCAL__test(checksum=True, initdb_params=params)
+
         # -----------
         logging.info("temp directory [{}] is deleting".format(tmp_dir))
         node_svc.os_ops.rmdir(tmp_dir)

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,6 @@ def make_simple(`
`112`	`112`	`final_initdb_params,`
`113`	`113`	`'--data-checksums'`
`114`	`114`	`)`
`115`		`- assert final_initdb_params is not initdb_params`
`116`	`115`	`assert final_initdb_params is not None`
`117`	`116`	`assert '--data-checksums' in final_initdb_params`
`118`	`117`