weird compatibility with private edition.

funny-falcon · funny-falcon · commit 9654c326fb3b · 2023-07-25T15:12:50.000+03:00
Well, it looks ugly. But in reality one should not see files &gt; 4GB in data
folder. If one puts such file there, ptrack already will produce garbage.
diff --git a/ptrack.c b/ptrack.c
@@ -394,7 +394,7 @@ ptrack_filelist_getnext(PtScanCtx * ctx)
 	ListCell   *cell;
 	char	   *fullpath;
 	struct stat fst;
-	off_t       rel_st_size = 0;
+	uint32_t	rel_st_size = 0;
 
 get_next:
 
@@ -444,16 +444,16 @@ ptrack_filelist_getnext(PtScanCtx * ctx)
 		goto get_next;
 	}
 
-	if (fst.st_size == 0)
+	rel_st_size = fst.st_size;
+
+	if (rel_st_size == 0)
 	{
 		elog(DEBUG3, "ptrack: skip empty file %s", fullpath);
 
 		/* But try the next one */
 		goto get_next;
 	}
 
-	rel_st_size = fst.st_size;
-
 	if (pfl->segno > 0)
 	{
 		ctx->relsize = pfl->segno * RELSEG_SIZE + rel_st_size / BLCKSZ;

Original file line number	Diff line number	Diff line change
`@@ -394,7 +394,7 @@ ptrack_filelist_getnext(PtScanCtx * ctx)`
`394`	`394`	`ListCell *cell;`
`395`	`395`	`char *fullpath;`
`396`	`396`	`struct stat fst;`
`397`		`- off_t rel_st_size = 0;`
	`397`	`+ uint32_t rel_st_size = 0;`
`398`	`398`
`399`	`399`	`get_next:`
`400`	`400`
`@@ -444,16 +444,16 @@ ptrack_filelist_getnext(PtScanCtx * ctx)`
`444`	`444`	`goto get_next;`
`445`	`445`	`}`
`446`	`446`
`447`		`- if (fst.st_size == 0)`
	`447`	`+ rel_st_size = fst.st_size;`
	`448`	`+`
	`449`	`+ if (rel_st_size == 0)`
`448`	`450`	`{`
`449`	`451`	`elog(DEBUG3, "ptrack: skip empty file %s", fullpath);`
`450`	`452`
`451`	`453`	`/* But try the next one */`
`452`	`454`	`goto get_next;`
`453`	`455`	`}`
`454`	`456`
`455`		`- rel_st_size = fst.st_size;`
`456`		`-`
`457`	`457`	`if (pfl->segno > 0)`
`458`	`458`	`{`
`459`	`459`	`ctx->relsize = pfl->segno * RELSEG_SIZE + rel_st_size / BLCKSZ;`