Merge pull request #11 from postgrespro/PGPRO-5646

ziva777 · web-flow · commit 71d4a97f0eb2 · 2021-10-22T11:46:00.000+03:00
PGPRO-5646: remove compiler warning (gcc 11.2.0)
diff --git a/engine.c b/engine.c
@@ -394,7 +394,17 @@ ptrackCheckpoint(void)
 	 *
 	 * Write both magic and varsion_num at once.
 	 */
-	ptrack_write_chunk(ptrack_tmp_fd, &crc, (char *) &ptrack_map->magic,
+
+	/*
+	 * Previously we read from the field magic, now we read from the beginning
+	 * of the structure PtrackMapHdr. Make sure nothing has changed since then.
+	 */
+	StaticAssertStmt(
+		offsetof(PtrackMapHdr, magic) == 0,
+		"old write format for PtrackMapHdr.magic and PtrackMapHdr.version_num "
+		"is not upward-compatible");
+
+	ptrack_write_chunk(ptrack_tmp_fd, &crc, (char *) ptrack_map,
 					   offsetof(PtrackMapHdr, init_lsn));
 
 	init_lsn = pg_atomic_read_u64(&ptrack_map->init_lsn);
