Enforce REPEATABLE READ since currently we export snap only once in xact

arssher · arssher · commit e1bacb7b5b5d · 2018-09-20T10:57:58.000+03:00
There is also no distribute predicate locking support, so SERIALIZABLE is not
the way to go too.
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
@@ -501,10 +501,15 @@ begin_remote_xact(ConnCacheEntry *entry)
 		elog(DEBUG3, "starting remote transaction on connection %p",
 			 entry->conn);
 
+		if (UseGlobalSnapshots && (!IsolationUsesXactSnapshot() ||
+								   IsolationIsSerializable()))
+			elog(ERROR, "Global snapshots support only REPEATABLE READ");
+
 		sprintf(sql, "START TRANSACTION %s; set application_name='pgfdw:%lld:%d';",
 				IsolationIsSerializable() ? "ISOLATION LEVEL SERIALIZABLE" :
 				UseRepeatableRead ? "ISOLATION LEVEL REPEATABLE READ" : "",
 				(long long) GetSystemIdentifier(), MyProcPid);
+
 		entry->changing_xact_state = true;
 		do_sql_command(entry, sql);
 		entry->xact_depth = 1;
diff --git a/contrib/postgres_fdw/t/001_bank_coordinator.pl b/contrib/postgres_fdw/t/001_bank_coordinator.pl
@@ -12,6 +12,7 @@
 	log_checkpoints = true
 	postgres_fdw.use_global_snapshots = on
 	track_global_snapshots = on
+	default_transaction_isolation = 'REPEATABLE READ'
 ));
 $master->start;
 
diff --git a/contrib/postgres_fdw/t/002_bank_participant.pl b/contrib/postgres_fdw/t/002_bank_participant.pl
@@ -12,6 +12,7 @@
 	postgres_fdw.use_global_snapshots = on
 	global_snapshot_defer_time = 15
 	track_global_snapshots = on
+    default_transaction_isolation = 'REPEATABLE READ'
 ));
 $shard1->start;
 
@@ -22,6 +23,7 @@
 	postgres_fdw.use_global_snapshots = on
 	global_snapshot_defer_time = 15
 	track_global_snapshots = on
+	default_transaction_isolation = 'REPEATABLE READ'
 ));
 $shard2->start;
 
