Run through toupper() conversion in the forward direction.

Thomas G. Lockhart · Thomas G. Lockhart · commit d7e0e61d847d · 1997-12-04T23:28:20.000Z
Most processors should optimize this a bit better wrt cache prefetch.
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.42 1997/12/01 22:02:49 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.43 1997/12/04 23:28:20 thomas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1697,7 +1697,7 @@ PQfnumber(PGresult *res, const char *field_name)
 		*(field_case + strlen(field_case) - 1) = '\0';
 	}
 	else
-		for (i = strlen(field_case); i >= 0; i--)
+		for (i = 0; i < strlen(field_case); i++)
 			if (isupper(field_case[i]))
 				field_case[i] = tolower(field_case[i]);
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.42 1997/12/01 22:02:49 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.43 1997/12/04 23:28:20 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1697,7 +1697,7 @@ PQfnumber(PGresult res, const char field_name)`
`1697`	`1697`	`*(field_case + strlen(field_case) - 1) = '\0';`
`1698`	`1698`	`}`
`1699`	`1699`	`else`
`1700`		`- for (i = strlen(field_case); i >= 0; i--)`
	`1700`	`+ for (i = 0; i < strlen(field_case); i++)`
`1701`	`1701`	`if (isupper(field_case[i]))`
`1702`	`1702`	`field_case[i] = tolower(field_case[i]);`
`1703`	`1703`