Add missing newline to error messages

petere · petere · commit d48f273b3144 · 2017-02-06T09:48:24.000-05:00
Also improve the message style a bit while we're here.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -11945,7 +11945,7 @@ dumpCast(Archive *fout, CastInfo *cast)
 	{
 		funcInfo = findFuncByOid(cast->castfunc);
 		if (funcInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  cast->castfunc);
 	}
 
@@ -12055,14 +12055,14 @@ dumpTransform(Archive *fout, TransformInfo *transform)
 	{
 		fromsqlFuncInfo = findFuncByOid(transform->trffromsql);
 		if (fromsqlFuncInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  transform->trffromsql);
 	}
 	if (OidIsValid(transform->trftosql))
 	{
 		tosqlFuncInfo = findFuncByOid(transform->trftosql);
 		if (tosqlFuncInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  transform->trftosql);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -11945,7 +11945,7 @@ dumpCast(Archive fout, CastInfo cast)`
`11945`	`11945`	`{`
`11946`	`11946`	`funcInfo = findFuncByOid(cast->castfunc);`
`11947`	`11947`	`if (funcInfo == NULL)`
`11948`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`11948`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`11949`	`11949`	`cast->castfunc);`
`11950`	`11950`	`}`
`11951`	`11951`
`@@ -12055,14 +12055,14 @@ dumpTransform(Archive fout, TransformInfo transform)`
`12055`	`12055`	`{`
`12056`	`12056`	`fromsqlFuncInfo = findFuncByOid(transform->trffromsql);`
`12057`	`12057`	`if (fromsqlFuncInfo == NULL)`
`12058`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`12058`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`12059`	`12059`	`transform->trffromsql);`
`12060`	`12060`	`}`
`12061`	`12061`	`if (OidIsValid(transform->trftosql))`
`12062`	`12062`	`{`
`12063`	`12063`	`tosqlFuncInfo = findFuncByOid(transform->trftosql);`
`12064`	`12064`	`if (tosqlFuncInfo == NULL)`
`12065`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`12065`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`12066`	`12066`	`transform->trftosql);`
`12067`	`12067`	`}`
`12068`	`12068`