Further marginal speed hacking: in MemoryContextReset, don't call

tglsfdc · tglsfdc · commit c8a6b5270508 · 2005-05-14T23:16:29.000Z
MemoryContextResetChildren unless necessary.
diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c
@@ -14,7 +14,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.54 2005/02/18 21:52:33 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.55 2005/05/14 23:16:29 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -123,7 +123,10 @@ MemoryContextReset(MemoryContext context)
 {
 	AssertArg(MemoryContextIsValid(context));
 
-	MemoryContextResetChildren(context);
+	/* save a function call in common case where there are no children */
+	if (context->firstchild != NULL)
+		MemoryContextResetChildren(context);
+
 	(*context->methods->reset) (context);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`*`
`15`	`15`	`*`
`16`	`16`	`* IDENTIFICATION`
`17`		`- * $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.54 2005/02/18 21:52:33 tgl Exp $`
	`17`	`+ * $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.55 2005/05/14 23:16:29 tgl Exp $`
`18`	`18`	`*`
`19`	`19`	`*-------------------------------------------------------------------------`
`20`	`20`	`*/`
`@@ -123,7 +123,10 @@ MemoryContextReset(MemoryContext context)`
`123`	`123`	`{`
`124`	`124`	`AssertArg(MemoryContextIsValid(context));`
`125`	`125`
`126`		`- MemoryContextResetChildren(context);`
	`126`	`+ /* save a function call in common case where there are no children */`
	`127`	`+ if (context->firstchild != NULL)`
	`128`	`+ MemoryContextResetChildren(context);`
	`129`	`+`
`127`	`130`	`(*context->methods->reset) (context);`
`128`	`131`	`}`
`129`	`132`