TEMPORARILY make synchronous_commit default to OFF, so that we can get more

tglsfdc · tglsfdc · commit b83bd31bd953 · 2007-08-13T19:27:12.000Z
thorough testing of async-commit mode from the buildfarm.  This patch MUST
get reverted before 8.3 release!
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.136 2007/08/04 01:26:53 tgl Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.137 2007/08/13 19:27:11 tgl Exp $ -->
 
 <chapter Id="runtime-config">
   <title>Server Configuration</title>
@@ -1352,6 +1352,14 @@ SET ENABLE_SEQSCAN TO OFF;
         commits.  It is therefore possible, and useful, to have some
         transactions commit synchronously and others asynchronously.
        </para>
+
+<!-- this note should go away before release!! -->
+<note>
+       <para>
+        For testing purposes, <varname>synchronous_commit</varname> will
+        default to <literal>off</> until 8.3 release approaches.
+       </para>
+</note>
       </listitem>
      </varlistentry>
      
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -10,7 +10,7 @@
  * Written by Peter Eisentraut <peter_e@gmx.net>.
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.411 2007/08/08 16:00:46 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.412 2007/08/13 19:27:11 tgl Exp $
  *
  *--------------------------------------------------------------------
  */
@@ -560,7 +560,8 @@ static struct config_bool ConfigureNamesBool[] =
 			NULL
 		},
 		&XactSyncCommit,
-		true, NULL, NULL
+		/* XXX TEMPORARY FOR TESTING: sync commit should default to TRUE! */
+		false, NULL, NULL
 	},
 	{
 		{"zero_damaged_pages", PGC_SUSET, DEVELOPER_OPTIONS,
diff --git a/src/tools/RELEASE_CHANGES b/src/tools/RELEASE_CHANGES
@@ -1,6 +1,10 @@
 For All Releases (major, minor, beta, RC)
 ================
 
+*** SPECIAL FOR 8.3: don't forget to revert patch of 2007-08-13 that
+made synchronous_commit default to OFF.  Affects this file, guc.c, and
+config.sgml.
+
 * Release version number changes
 	o doc/bug.template
 	o bump Win32 interface version numbers

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.411 2007/08/08 16:00:46 tgl Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.412 2007/08/13 19:27:11 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -560,7 +560,8 @@ static struct config_bool ConfigureNamesBool[] =`
`560`	`560`	`NULL`
`561`	`561`	`},`
`562`	`562`	`&XactSyncCommit,`
`563`		`- true, NULL, NULL`
	`563`	`+ /* XXX TEMPORARY FOR TESTING: sync commit should default to TRUE! */`
	`564`	`+ false, NULL, NULL`
`564`	`565`	`},`
`565`	`566`	`{`
`566`	`567`	`{"zero_damaged_pages", PGC_SUSET, DEVELOPER_OPTIONS,`