Add assertion to quiet Coverity

petere · petere · commit b1ff33fd9bb8 · 2017-05-15T13:59:58.000-04:00
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
@@ -69,6 +69,9 @@ parse_subscription_options(List *options, bool *connect, bool *enabled_given,
 	bool		create_slot_given = false;
 	bool		copy_data_given = false;
 
+	/* If connect is specified, the others also need to be. */
+	Assert(!connect || (enabled && create_slot && copy_data));
+
 	if (connect)
 		*connect = true;
 	if (enabled)
