Message style improvements

petere · petere · commit 9d775d889466 · 2013-08-07T22:48:40.000-04:00
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
@@ -672,7 +672,7 @@ transformTableLikeClause(CreateStmtContext *cxt, TableLikeClause *table_like_cla
 	if (cxt->isforeign)
 		ereport(ERROR,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-				 errmsg("LIKE is not supported for foreign tables")));
+				 errmsg("LIKE is not supported for creating foreign tables")));
 
 	relation = relation_openrv(table_like_clause->relation, AccessShareLock);
 
diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port/sysv_shmem.c
@@ -174,7 +174,7 @@ InternalIpcMemoryCreate(IpcMemoryKey memKey, Size size)
 						 "memory configuration.") : 0,
 				 (errno == ENOMEM) ?
 				 errhint("This error usually means that PostgreSQL's request for a shared "
-						 "memory segment exceeded your kernel's SHMALL parameter.  You may need "
+						 "memory segment exceeded your kernel's SHMALL parameter.  You might need "
 						 "to reconfigure the kernel with larger SHMALL.\n"
 		"The PostgreSQL documentation contains more information about shared "
 						 "memory configuration.") : 0,
diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c
@@ -255,7 +255,7 @@ BackgroundWorkerStateChange(void)
 
 		/* Log it! */
 		ereport(LOG,
-				(errmsg("registering background worker: %s",
+				(errmsg("registering background worker \"%s\"",
 					rw->rw_worker.bgw_name)));
 
 		slist_push_head(&BackgroundWorkerList, &rw->rw_lnode);
@@ -284,7 +284,7 @@ ForgetBackgroundWorker(slist_mutable_iter *cur)
 	slot->in_use = false;
 
 	ereport(LOG,
-			(errmsg("unregistering background worker: %s",
+			(errmsg("unregistering background worker \"%s\"",
 				rw->rw_worker.bgw_name)));
 
 	slist_delete_current(cur);
@@ -368,7 +368,7 @@ RegisterBackgroundWorker(BackgroundWorker *worker)
 
 	if (!IsUnderPostmaster)
 		ereport(LOG,
-			(errmsg("registering background worker: %s", worker->bgw_name)));
+			(errmsg("registering background worker \"%s\"", worker->bgw_name)));
 
 	if (!process_shared_preload_libraries_in_progress)
 	{
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -5224,7 +5224,7 @@ BackgroundWorkerInitializeConnection(char *dbname, char *username)
 	/* it had better not gotten out of "init" mode yet */
 	if (!IsInitProcessingMode())
 		ereport(ERROR,
-				(errmsg("invalid processing mode in bgworker")));
+				(errmsg("invalid processing mode in background worker")));
 	SetProcessingMode(NormalProcessing);
 }
 
diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c
@@ -1836,7 +1836,7 @@ populate_recordset_array_element_start(void *state, bool isnull)
 		_state->lex->token_type != JSON_TOKEN_OBJECT_START)
 		ereport(ERROR,
 				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-			 errmsg("must call populate_recordset on an array of objects")));
+			 errmsg("must call json_populate_recordset on an array of objects")));
 }
 
 static void
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -1607,7 +1607,7 @@ static struct config_int ConfigureNamesInt[] =
 
 	{
 		{"wal_receiver_timeout", PGC_SIGHUP, REPLICATION_STANDBY,
-			gettext_noop("Sets the maximum wait time to receive data from master."),
+			gettext_noop("Sets the maximum wait time to receive data from the primary."),
 			NULL,
 			GUC_UNIT_MS
 		},

Original file line number	Diff line number	Diff line change
`@@ -5224,7 +5224,7 @@ BackgroundWorkerInitializeConnection(char dbname, char username)`
`5224`	`5224`	`/* it had better not gotten out of "init" mode yet */`
`5225`	`5225`	`if (!IsInitProcessingMode())`
`5226`	`5226`	`ereport(ERROR,`
`5227`		`- (errmsg("invalid processing mode in bgworker")));`
	`5227`	`+ (errmsg("invalid processing mode in background worker")));`
`5228`	`5228`	`SetProcessingMode(NormalProcessing);`
`5229`	`5229`	`}`
`5230`	`5230`
Original file line number	Diff line number	Diff line change
`@@ -1836,7 +1836,7 @@ populate_recordset_array_element_start(void *state, bool isnull)`
`1836`	`1836`	`_state->lex->token_type != JSON_TOKEN_OBJECT_START)`
`1837`	`1837`	`ereport(ERROR,`
`1838`	`1838`	`(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`1839`		`- errmsg("must call populate_recordset on an array of objects")));`
	`1839`	`+ errmsg("must call json_populate_recordset on an array of objects")));`
`1840`	`1840`	`}`
`1841`	`1841`
`1842`	`1842`	`static void`
Original file line number	Diff line number	Diff line change
`@@ -1607,7 +1607,7 @@ static struct config_int ConfigureNamesInt[] =`
`1607`	`1607`
`1608`	`1608`	`{`
`1609`	`1609`	`{"wal_receiver_timeout", PGC_SIGHUP, REPLICATION_STANDBY,`
`1610`		`- gettext_noop("Sets the maximum wait time to receive data from master."),`
	`1610`	`+ gettext_noop("Sets the maximum wait time to receive data from the primary."),`
`1611`	`1611`	`NULL,`
`1612`	`1612`	`GUC_UNIT_MS`
`1613`	`1613`	`},`