Make oldSnapshotControl a pointer to a volatile structure

kgrittn · kgrittn · commit 80647bf65a03 · 2016-04-11T15:43:52.000-05:00
It was incorrectly declared as a volatile pointer to a non-volatile
structure.  Eliminate the OldSnapshotControl struct definition; it
is really not needed.  Pointed out by Tom Lane.

While at it, add OldSnapshotControlData to pgindent's list of
structures.
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
@@ -117,9 +117,7 @@ typedef struct OldSnapshotControlData
 	TransactionId xid_by_minute[FLEXIBLE_ARRAY_MEMBER];
 }	OldSnapshotControlData;
 
-typedef struct OldSnapshotControlData *OldSnapshotControl;
-
-static volatile OldSnapshotControl oldSnapshotControl;
+static volatile OldSnapshotControlData *oldSnapshotControl; 
 
 
 /*
@@ -259,9 +257,9 @@ SnapMgrInit(void)
 	bool		found;
 
 	/*
-	 * Create or attach to the OldSnapshotControl structure.
+	 * Create or attach to the OldSnapshotControlData structure.
 	 */
-	oldSnapshotControl = (OldSnapshotControl)
+	oldSnapshotControl = (volatile OldSnapshotControlData *)
 		ShmemInitStruct("OldSnapshotControlData",
 						SnapMgrShmemSize(), &found);
 
diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list
@@ -1175,6 +1175,7 @@ Oid
 OidOptions
 OkeysState
 OldSerXidControl
+OldSnapshotControlData
 OldToNewMapping
 OldToNewMappingData
 OldTriggerInfo
