The recent DUMMY_PROCS patch broke accounting for the number of semaphores

tglsfdc · tglsfdc · commit 772d0f9345ad · 2003-12-21T00:33:33.000Z
needed.  This caused us to fail all the time on Darwin, and we'd fail for
some values of maxBackends on SysV-sema platforms, too.
diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/lmgr/proc.c,v 1.141 2003/12/20 17:31:21 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/lmgr/proc.c,v 1.142 2003/12/21 00:33:33 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -95,8 +95,8 @@ static bool CheckStatementTimeout(void);
 int
 ProcGlobalSemas(int maxBackends)
 {
-	/* We need a sema per backend, plus one for the dummy process. */
-	return maxBackends + 1;
+	/* We need a sema per backend, plus one for each dummy process. */
+	return maxBackends + NUM_DUMMY_PROCS;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/lmgr/proc.c,v 1.141 2003/12/20 17:31:21 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/lmgr/proc.c,v 1.142 2003/12/21 00:33:33 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -95,8 +95,8 @@ static bool CheckStatementTimeout(void);`
`95`	`95`	`int`
`96`	`96`	`ProcGlobalSemas(int maxBackends)`
`97`	`97`	`{`
`98`		`- /* We need a sema per backend, plus one for the dummy process. */`
`99`		`- return maxBackends + 1;`
	`98`	`+ /* We need a sema per backend, plus one for each dummy process. */`
	`99`	`+ return maxBackends + NUM_DUMMY_PROCS;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`/*`