Downgrade subscription refresh messages to DEBUG1

petere · petere · commit 6f81306e4d17 · 2017-08-07T09:16:03.000-04:00
The NOTICE messages about tables being added or removed during subscription refresh would be incorrect and possibly confusing if the transaction rolls back, so silence them but keep them available for debugging. Discussion: https://www.postgresql.org/message-id/CAD21AoAvaXizc2h7aiNyK_i0FQSa-tmhpdOGwbhh7Jy544Ad4Q%40mail.gmail.com
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
@@ -572,7 +572,7 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data)
 			SetSubscriptionRelState(sub->oid, relid,
 									copy_data ? SUBREL_STATE_INIT : SUBREL_STATE_READY,
 									InvalidXLogRecPtr, false);
-			ereport(NOTICE,
+			ereport(DEBUG1,
 					(errmsg("added subscription for table %s.%s",
 							quote_identifier(rv->schemaname),
 							quote_identifier(rv->relname))));
@@ -600,7 +600,7 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data)
 			logicalrep_worker_stop_at_commit(sub->oid, relid);
 
 			namespace = get_namespace_name(get_rel_namespace(relid));
-			ereport(NOTICE,
+			ereport(DEBUG1,
 					(errmsg("removed subscription for table %s.%s",
 							quote_identifier(namespace),
 							quote_identifier(get_rel_name(relid)))));
