Prevent logging "failed to stat file: success" for temp files

mhagander · mhagander · commit 672614cf2137 · 2012-01-28T10:03:26.000+01:00
This was broken in commit bc33474, the addition of statistics counters for temp files. Reported by Thom Brown
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -1128,11 +1128,11 @@ FileClose(File file)
 									vfdP->fileName,
 									(unsigned long) filestats.st_size)));
 			}
-			else
-			{
-				errno = stat_errno;
-				elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);
-			}
+		}
+		else
+		{
+			errno = stat_errno;
+			elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1128,11 +1128,11 @@ FileClose(File file)`
`1128`	`1128`	`vfdP->fileName,`
`1129`	`1129`	`(unsigned long) filestats.st_size)));`
`1130`	`1130`	`}`
`1131`		`- else`
`1132`		`- {`
`1133`		`- errno = stat_errno;`
`1134`		`- elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);`
`1135`		`- }`
	`1131`	`+ }`
	`1132`	`+ else`
	`1133`	`+ {`
	`1134`	`+ errno = stat_errno;`
	`1135`	`+ elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);`
`1136`	`1136`	`}`
`1137`	`1137`	`}`
`1138`	`1138`