Add comment about COMMENT ON DATABASE failing for differently-named

bmomjian · bmomjian · commit 3b65c3b2e7db · 2007-11-19T18:44:06.000Z
databases.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.477 2007/11/15 22:25:16 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.478 2007/11/19 18:44:06 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1530,6 +1530,7 @@ dumpDatabase(Archive *AH)
 		if (comment && strlen(comment))
 		{
 			resetPQExpBuffer(dbQry);
+			/* This will fail when loaded into a database with a different name. */
 			appendPQExpBuffer(dbQry, "COMMENT ON DATABASE %s IS ", fmtId(datname));
 			appendStringLiteralAH(dbQry, comment, AH);
 			appendPQExpBuffer(dbQry, ";\n");

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.477 2007/11/15 22:25:16 momjian Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.478 2007/11/19 18:44:06 momjian Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -1530,6 +1530,7 @@ dumpDatabase(Archive *AH)`
`1530`	`1530`	`if (comment && strlen(comment))`
`1531`	`1531`	`{`
`1532`	`1532`	`resetPQExpBuffer(dbQry);`
	`1533`	`+ /* This will fail when loaded into a database with a different name. */`
`1533`	`1534`	`appendPQExpBuffer(dbQry, "COMMENT ON DATABASE %s IS ", fmtId(datname));`
`1534`	`1535`	`appendStringLiteralAH(dbQry, comment, AH);`
`1535`	`1536`	`appendPQExpBuffer(dbQry, ";\n");`