Improve dpow() check for ERANGE overflow for HPPA.

bmomjian · bmomjian · commit 19ce06b91bfb · 2007-01-06T04:14:55.000Z
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.143 2007/01/06 02:28:38 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.144 2007/01/06 04:14:55 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1459,10 +1459,9 @@ dpow(PG_FUNCTION_ARGS)
 		else
 			result = 1;
 	}
-	else if (errno == ERANGE)
-	{
-		result = (arg1 >= 0) ? get_float8_infinity() : -get_float8_infinity();
-	}
+	/* Some platoforms, e.g. HPPA, return ERANGE, but HUGE_VAL, not Inf */
+	else if (errno == ERANGE && !isinf(result))
+		result = get_float8_infinity();
 	
 	CHECKFLOATVAL(result, isinf(arg1) || isinf(arg2), arg1 == 0);
 	PG_RETURN_FLOAT8(result);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.143 2007/01/06 02:28:38 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.144 2007/01/06 04:14:55 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1459,10 +1459,9 @@ dpow(PG_FUNCTION_ARGS)`
`1459`	`1459`	`else`
`1460`	`1460`	`result = 1;`
`1461`	`1461`	`}`
`1462`		`- else if (errno == ERANGE)`
`1463`		`- {`
`1464`		`- result = (arg1 >= 0) ? get_float8_infinity() : -get_float8_infinity();`
`1465`		`- }`
	`1462`	`+ /* Some platoforms, e.g. HPPA, return ERANGE, but HUGE_VAL, not Inf */`
	`1463`	`+ else if (errno == ERANGE && !isinf(result))`
	`1464`	`+ result = get_float8_infinity();`
`1466`	`1465`
`1467`	`1466`	`CHECKFLOATVAL(result, isinf(arg1) \|\| isinf(arg2), arg1 == 0);`
`1468`	`1467`	`PG_RETURN_FLOAT8(result);`