Adjust error message for partial writes in WAL segments

michaelpq · michaelpq · commit f2d84a4a6b4e · 2019-03-11T09:31:25.000+09:00
93473c6 has removed openLogOff, changing on the way the error message which is used to report partial writes to WAL segments. The newly-introduced error message used the offset up to which the write has happened, keeping always the same total length to write. This changes the error message so as the number of bytes left to write are reported. Reported-by: Michael Paquier Author: Robert Haas Discussion: https://postgr.es/m/20190306235251.GA17293@paquier.xyz
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -2504,7 +2504,7 @@ XLogWrite(XLogwrtRqst WriteRqst, bool flexible)
 							 errmsg("could not write to log file %s "
 									"at offset %u, length %zu: %m",
 									XLogFileNameP(ThisTimeLineID, openLogSegNo),
-									startoffset, nbytes)));
+									startoffset, nleft)));
 				}
 				nleft -= written;
 				from += written;

Original file line number	Diff line number	Diff line change
`@@ -2504,7 +2504,7 @@ XLogWrite(XLogwrtRqst WriteRqst, bool flexible)`
`2504`	`2504`	`errmsg("could not write to log file %s "`
`2505`	`2505`	`"at offset %u, length %zu: %m",`
`2506`	`2506`	`XLogFileNameP(ThisTimeLineID, openLogSegNo),`
`2507`		`- startoffset, nbytes)));`
	`2507`	`+ startoffset, nleft)));`
`2508`	`2508`	`}`
`2509`	`2509`	`nleft -= written;`
`2510`	`2510`	`from += written;`