8000 Remove CustomPath's TextOutCustomPath method. · postgrespro/postgres@f2305d4 · GitHub
[go: up one dir, main page]
Skip to content

    • Commit f2305d4

    Browse files
    robertmhaasrobertmhaas
    committed
    Remove CustomPath's TextOutCustomPath method.
    You can't really do anything useful with this in the form it currently exists; among other problems, there's no way to reread whatever information might be produced when the path is output. Work is underway to replace this with a more useful and more general system of extensible nodes, but let's start by getting rid of this bit. Extracted from a larger patch by KaiGai Kohei.
    1 parent dc203dc commit f2305d4

    File tree

    3 files changed

    +0
    -18
    lines changed

    3 files changed

    +0
    -18
    lines changed

    ‎doc/src/sgml/custom-scan.sgml

    Lines changed: 0 additions & 13 deletions
    Original file line numberDiff line numberDiff line change
    @@ -125,19 +125,6 @@ Plan *(*PlanCustomPath) (PlannerInfo *root,
    125125
    be a <literal>CustomScan</> object, which the callback must allocate and
    126126
    initialize. See <xref linkend="custom-scan-plan"> for more details.
    127127
    </para>
    128-
    129-
    <para>
    130-
    <programlisting>
    131-
    void (*TextOutCustomPath) (StringInfo str,
    132-
    const CustomPath *node);
    133-
    </programlisting>
    134-
    Generate additional output when <function>nodeToString</> is invoked on
    135-
    this custom path. This callback is optional. Since
    136-
    <function>nodeToString</> will automatically dump all fields in the
    137-
    structure that it can see, including <structfield>custom_private</>, this
    138-
    is only useful if the <structname>CustomPath</> is actually embedded in a
    139-
    larger struct containing additional fields.
    140-
    </para>
    141128
    </sect2>
    142129
    </sect1>
    143130

    ‎src/backend/nodes/outfuncs.c

    Lines changed: 0 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -1705,8 +1705,6 @@ _outCustomPath(StringInfo str, const CustomPath *node)
    17051705
    WRITE_NODE_FIELD(custom_private);
    17061706
    appendStringInfoString(str, " :methods ");
    17071707
    _outToken(str, node->methods->CustomName);
    1708-
    if (node->methods->TextOutCustomPath)
    1709-
    node->methods->TextOutCustomPath(str, node);
    17101708
    }
    17111709

    17121710
    static void

    ‎src/include/nodes/relation.h

    Lines changed: 0 additions & 3 deletions
    Original file line numberDiff line numberDiff line change
    @@ -958,9 +958,6 @@ typedef struct CustomPathMethods
    958958
    List *tlist,
    959959
    List *clauses,
    960960
    List *custom_plans);
    961-
    /* Optional: print additional fields besides "private" */
    962-
    void (*TextOutCustomPath) (StringInfo str,
    963-
    const struct CustomPath *node);
    964961
    } CustomPathMethods;
    965962

    966963
    typedef struct CustomPath

    0 commit comments

    Comments
     (0)
    0