8000 Fix inconsistencies and typos in the tree · postgrespro/postgres@eb43f3d · GitHub
[go: up one dir, main page]
Skip to content

Commit eb43f3d

Browse files
michaelpqmichaelpq
committed
Fix inconsistencies and typos in the tree
This is numbered take 8, and addresses again a set of issues with code comments, variable names and unreferenced variables. Author: Alexander Lakhin Discussion: https://postgr.es/m/b137b5eb-9c95-9c2f-586e-38aba7d59788@gmail.com
1 parent 7cce159 commit eb43f3d

File tree

42 files changed

+58
-75
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+58
-75
lines changed

‎contrib/pgcrypto/pgp-decrypt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ mdc_finish(PGP_Context *ctx, PullFilter *src, int len)
355355
if (len != 20)
356356
return PXE_PGP_CORRUPT_DATA;
357357

358-
/* mdc_read should not call md_update */
358+
/* mdc_read should not call px_md_update */
359359
ctx->in_mdc_pkt = 1;
360360

361361
/* read data */

‎doc/src/sgml/custom-scan.sgml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,7 @@ typedef struct CustomPath
8383
by <literal>nodeToString</literal>, so that debugging routines that attempt to
8484
print the custom path will work as designed. <structfield>methods</structfield> must
8585
point to a (usually statically allocated) object implementing the required
86-
custom path methods, of which there is currently only one. The
87-
<structfield>LibraryName</structfield> and <structfield>SymbolName</structfield> fields must also
88-
be initialized so that the dynamic loader can resolve them to locate the
89-
method table.
86+
custom path methods, of which there is currently only one.
9087
</para>
9188

9289
<para>

‎doc/src/sgml/ref/create_aggregate.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ CREATE [ OR REPLACE ] AGGREGATE <replaceable class="parameter">name</replaceable
211211
as described in <xref linkend="xaggr-moving-aggregates"/>. This requires
212212
specifying the <literal>MSFUNC</literal>, <literal>MINVFUNC</literal>,
213213
and <literal>MSTYPE</literal> parameters, and optionally
214-
the <literal>MSPACE</literal>, <literal>MFINALFUNC</literal>,
214+
the <literal>MSSPACE</literal>, <literal>MFINALFUNC</literal>,
215215
<literal>MFINALFUNC_EXTRA</literal>, <literal>MFINALFUNC_MODIFY</literal>,
216216
and <literal>MINITCOND</literal> parameters. Except for <literal>MINVFUNC</literal>,
217217
these parameters work like the corresponding simple-aggregate parameters

‎doc/src/sgml/xplang.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ CREATE FUNCTION <replaceable>validator_function_name</replaceable>(oid)
137137
<para>
138138
Finally, the PL must be declared with the command
139139
<synopsis>
140-
CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language-name</replaceable>
140+
CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language_name</replaceable>
141141
HANDLER <replaceable>handler_function_name</replaceable>
142142
<optional>INLINE <replaceable>inline_function_name</replaceable></optional>
143143
<optional>VALIDATOR <replaceable>validator_function_name</replaceable></optional> ;

‎src/Makefile.global.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ standard_targets = all install installdirs uninstall distprep clean distclean ma
2323
# these targets should recurse even into subdirectories not being built:
2424
standard_always_targets = distprep clean distclean maintainer-clean
2525

26-
.PHONY: $(standard_targets) install-strip html man installcheck-parallel maintainer-check
26+
.PHONY: $(standard_targets) install-strip html man installcheck-parallel
2727

2828
# make `all' the default target
2929
all:

‎src/backend/access/common/bufmask.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "access/bufmask.h"
2121

2222
/*
23-
* mask_page_lsn
23+
* mask_page_lsn_and_checksum
2424
*
2525
* In consistency checks, the LSN of the two pages compared will likely be
2626
* different because of concurrent operations when the WAL is generated and

‎src/backend/access/gin/gindatapage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ disassembleLeaf(Page page)
13711371
if (GinPageIsCompressed(page))
13721372
{
13731373
/*
1374-
* Create a leafSegment entry for each segment.
1374+
* Create a leafSegmentInfo entry for each segment.
13751375
*/
13761376
seg = GinDataLeafPageGetPostingList(page);
13771377
segbegin = (Pointer) seg;

‎src/backend/access/heap/rewriteheap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ static void logical_end_heap_rewrite(RewriteState state);
237237
* new_heap new, locked heap relation to insert tuples to
238238
* oldest_xmin xid used by the caller to determine which tuples are dead
239239
* freeze_xid xid before which tuples will be frozen
240-
* min_multi multixact before which multis will be removed
240+
* cutoff_multi multixact before which multis will be removed
241241
* use_wal should the inserts to the new heap be WAL-logged?
242242
*
243243
* Returns an opaque RewriteState, allocated in current memory context,
@@ -787,7 +787,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)
787787
* Instead we simply write the mapping files out to disk, *before* the
788788
* XLogInsert() is performed. That guarantees that either the XLogInsert() is
789789
* inserted after the checkpoint's redo pointer or that the checkpoint (via
790-
* LogicalRewriteHeapCheckpoint()) has flushed the (partial) mapping file to
790+
* CheckPointLogicalRewriteHeap()) has flushed the (partial) mapping file to
791791
* disk. That leaves the tail end that has not yet been flushed open to
792792
* corruption, which is solved by including the current offset in the
793793
* xl_heap_rewrite_mapping records and truncating the mapping file to it

‎src/backend/access/spgist/spgvacuum.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ spgvacuumscan(spgBulkDeleteState *bds)
842842
}
843843
}
844844

845-
/* Propagate local lastUsedPage cache to metablock */
845+
/* Propagate local lastUsedPages cache to metablock */
846846
SpGistUpdateMetaPage(index);
847847

848848
/*

‎src/backend/access/transam/xact.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1988,7 +1988,7 @@ StartTransaction(void)
19881988

19891989
/*
19901990
* Advertise it in the proc array. We assume assignment of
1991-
* LocalTransactionID is atomic, and the backendId should be set already.
1991+
* localTransactionId is atomic, and the backendId should be set already.
19921992
*/
19931993
Assert(MyProc->backendId == vxid.backendId);
19941994
MyProc->lxid = vxid.localTransactionId;

0 commit comments

Comments
 (0)
0