Disable tests using injection points in installcheck

hlinnaka · hlinnaka · commit e2e3b8ae9ed7 · 2024-03-15T13:06:57.000+02:00
The 'gin' test injections faults to GIN index build. If another test running concurrently in the same cluster also tries to create a GIN index, it will hit the fault, too. To fix, disable tests using injection points when running against an existing cluster. A better long-term solution would be to make the injection points scoped to the database or process, but this will do for now. Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8yamQ@mail.gmail.com Discussion: https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi
diff --git a/src/test/modules/gin/Makefile b/src/test/modules/gin/Makefile
@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
 
 REGRESS = gin_incomplete_splits
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/gin/meson.build b/src/test/modules/gin/meson.build
@@ -12,5 +12,7 @@ tests += {
     'sql': [
       'gin_incomplete_splits',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }
diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile
@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
 
 REGRESS = injection_points
 
+# The injection points are cluster-wide, so disable installcheck
+NO_INSTALLCHECK = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build
@@ -33,5 +33,7 @@ tests += {
     'sql': [
       'injection_points',
     ],
+    # The injection points are cluster-wide, so disable installcheck
+    'runningcheck': false,
   },
 }

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,7 @@ tests += {`
`12`	`12`	`'sql': [`
`13`	`13`	`'gin_incomplete_splits',`
`14`	`14`	`],`
	`15`	`+ # The injection points are cluster-wide, so disable installcheck`
	`16`	`+ 'runningcheck': false,`
`15`	`17`	`},`
`16`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,7 @@ tests += {`
`33`	`33`	`'sql': [`
`34`	`34`	`'injection_points',`
`35`	`35`	`],`
	`36`	`+ # The injection points are cluster-wide, so disable installcheck`
	`37`	`+ 'runningcheck': false,`
`36`	`38`	`},`
`37`	`39`	`}`