8000 PostgresNode: Add names to nodes · postgrespro/postgres@c8642d9 · GitHub
[go: up one dir, main page]
Skip to content

Commit c8642d9

Browse files
alvherrealvherre
committed
PostgresNode: Add names to nodes
This makes the log files easier to follow when investigating a test failure. Author: Michael Paquier Review: Noah Misch
1 parent 216d568 commit c8642d9

20 files changed

+48
-37
lines changed

‎src/bin/pg_basebackup/t/010_pg_basebackup.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
my $tempdir = TestLib::tempdir;
1414

15-
my $node = get_new_node();
15+
my $node = get_new_node('main');
1616

1717
# Initialize node without replication settings
1818
$node->init(hba_permit_replication => 0);

‎src/bin/pg_controldata/t/001_pg_controldata.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
command_fails([ 'pg_controldata', 'nonexistent' ],
1212
'pg_controldata with nonexistent directory fails');
1313

14-
my $node = get_new_node();
14+
my $node = get_new_node('main');
1515
$node->init;
1616

1717
command_like([ 'pg_controldata', $node->data_dir ],

‎src/bin/pg_ctl/t/002_status.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
command_exit_is([ 'pg_ctl', 'status', '-D', "$tempdir/nonexistent" ],
1212
4, 'pg_ctl status with nonexistent directory');
1313

14-
my $node = get_new_node();
14+
my $node = get_new_node('main');
1515
$node->init;
1616

1717
command_exit_is([ 'pg_ctl', 'status', '-D', $node->data_dir ],

‎src/bin/pg_rewind/RewindTest.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ sub setup_cluster
116116
{
117117

118118
# Initialize master, data checksums are mandatory
119-
$node_master = get_new_node();
119+
$node_master = get_new_node('master');
120120
$node_master->init;
121121

122122
# Custom parameters for master's postgresql.conf
@@ -144,7 +144,7 @@ sub start_master
144144

145145
sub create_standby
146146
{
147-
$node_standby = get_new_node();
147+
$node_standby = get_new_node('standby');
148148
$node_master->backup('my_backup');
149149
$node_standby->init_from_backup($node_master, 'my_backup');
150150
my $connstr_master = $node_master->connstr('postgres');

‎src/bin/scripts/t/010_clusterdb.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
program_version_ok('clusterdb');
1010
program_options_handling_ok('clusterdb');
1111

12-
my $node = get_new_node();
12+
my $node = get_new_node('main');
1313
$node->init;
1414
$node->start;
1515

‎src/bin/scripts/t/011_clusterdb_all.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use TestLib;
66
use Test::More tests => 2;
77

8-
my $node = get_new_node();
8+
my $node = get_new_node('main');
99
$node->init;
1010
$node->start;
1111

‎src/bin/scripts/t/020_createdb.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
program_version_ok('createdb');
1010
program_options_handling_ok('createdb');
1111

12-
my $node = get_new_node();
12+
my $node = get_new_node('main');
1313
$node->init;
1414
$node->start;
1515

‎src/bin/scripts/t/030_createlang.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
program_version_ok('createlang');
1010
program_options_handling_ok('createlang');
1111

12-
my $node = get_new_node();
12+
my $node = get_new_node('main');
1313
$node->init;
1414
$node->start;
1515

‎src/bin/scripts/t/040_createuser.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
program_version_ok('createuser');
1010
program_options_handling_ok('createuser');
1111

12-
my $node = get_new_node();
12+
my $node = get_new_node('main');
1313
$node->init;
1414
$node->start;
1515

‎src/bin/scripts/t/050_dropdb.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
program_version_ok('dropdb');
1010
program_options_handling_ok('dropdb');
1111

12-
my $node = get_new_node();
12+
my $node = get_new_node('main');
1313
$node->init;
1414
$node->start;
1515

0 commit comments

Comments
 (0)
0