8000 Further weaken new pg_createsubscriber test on Windows. · postgrespro/postgres@a1333ec · GitHub
[go: up one dir, main page]
Skip to content

    • Commit a1333ec

    Browse files
    tglsfdctglsfdc
    committed
    Further weaken new pg_createsubscriber test on Windows.
    Also omit backslashes (\) in the generated database names on Windows. As before, perhaps we can revert this after updating affected buildfarm animals. Discussion: https://postgr.es/m/2509767.1719773880@sss.pgh.pa.us
    1 parent 797adaf commit a1333ec

    File tree

    1 file changed

    +3
    -2
    lines changed

    1 file changed

    +3
    -2
    lines changed

    ‎src/bin/pg_basebackup/t/040_pg_createsubscriber.pl

    Lines changed: 3 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -30,8 +30,9 @@ sub generate_db
    3030

    3131
    $dbname .= $suffix;
    3232

    33-
    # Old IPC::Run mis-quotes command line arguments containing '"' on Windows
    34-
    $dbname =~ tr/\"//d if ($windows_os);
    33+
    # On Windows, older IPC::Run versions can mis-quote command line arguments
    34+
    # containing double quote or backslash
    35+
    $dbname =~ tr/\"\\//d if ($windows_os);
    3536

    3637
    $node->command_ok(
    3738
    [ 'createdb', $dbname ],

    0 commit comments

    Comments
     (0)
    0