Always skip recovery SysV shared memory tests on Windows

adunstan · adunstan · commit 8e5ce1c3f837 · 2019-09-06T15:50:53.000-04:00
The test for SysV support currently involves looking for the perl modules IPC::SharedMem and IPC::SysV. However, the perl on msys2 has these modules but the tests fail. Therefore, force skipping the tests on Windows platforms unconditionally. Discussion: https://postgr.es/m/176e86ba-1a46-9d8c-5ae4-9865a463b411@2ndQuadrant.com
diff --git a/src/test/recovery/t/017_shm.pl b/src/test/recovery/t/017_shm.pl
@@ -18,7 +18,7 @@
 	require IPC::SysV;
 	IPC::SysV->import(qw(IPC_CREAT IPC_EXCL S_IRUSR S_IWUSR));
 };
-if ($@)
+if ($@ || $windows_os)
 {
 	plan skip_all => 'SysV shared memory not supported by this platform';
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`require IPC::SysV;`
`19`	`19`	`IPC::SysV->import(qw(IPC_CREAT IPC_EXCL S_IRUSR S_IWUSR));`
`20`	`20`	`};`
`21`		`-if ($@)`
	`21`	`+if ($@ \|\| $windows_os)`
`22`	`22`	`{`
`23`	`23`	`plan skip_all => < 3CA7 span class="pl-s">'SysV shared memory not supported by this platform';`
`24`	`24`	`}`