8000 Fix regression test handling of test_decoding with MSVC · postgrespro/postgres@3955cae · GitHub
[go: up one dir, main page]
Skip to content

    • Commit 3955cae

    Browse files
    michaelpqmichaelpq
    committed
    Fix regression test handling of test_decoding with MSVC
    The set of scripts in charge of running the regression tests for MSVC run currently under the assumption that only $(top_builddir) can used in option values defined in REGRESS_OPTS, and those options need to have a specific format as well to be correctly parsed, so fix the Makefile values so as those are correctly set. Per complains from buildfarm member dory and whelk, with some extra testing done on my side with MSVC to check this patch.
    1 parent b0b1f41 commit 3955cae

    File tree

    1 file changed

    +2
    -2
    lines changed

    1 file changed

    +2
    -2
    lines changed

    ‎contrib/test_decoding/Makefile

    Lines changed: 2 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -11,8 +11,8 @@ REGRESS = ddl xact rewrite toast permissions decoding_in_xact \
    1111
    ISOLATION = mxact delayed_startup ondisk_startup concurrent_ddl_dml \
    1212
    oldest_xmin snapshot_transfer
    1313

    14-
    REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf
    15-
    ISOLATION_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf
    14+
    REGRESS_OPTS = --temp-config=$(top_builddir)/contrib/test_decoding/logical.conf
    15+
    ISOLATION_OPTS = --temp-config=$(top_builddir)/contrib/test_decoding/logical.conf
    1616

    1717
    # Disabled because these tests require "wal_level=logical", which
    1818
    # typical installcheck users do not have (e.g. buildfarm clients).

    0 commit comments

    Comments
     (0)
    0