8000 Another version of installcheck to run docker tests correctly · postgrespro/pg_query_state@5a2486d · GitHub
[go: up one dir, main page]

Skip to content

Commit 5a2486d

Browse files
committed
Another version of installcheck to run docker tests correctly
1 parent 93eda98 commit 5a2486d

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

Makefile

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,16 @@ include $(top_builddir)/src/Makefile.global
2222
include $(top_srcdir)/contrib/contrib-global.mk
2323
endif
2424

25+
EXTRA_REGRESS_OPTS=--temp-config=$(top_srcdir)/$(subdir)/test.conf
26+
2527
$(EXTENSION)--$(EXTVERSION).sql: init.sql
2628
cat $^ > $@
2729

2830
ISOLATIONCHECKS=corner_cases
2931

3032
check: isolationcheck
3133

32-
installcheck:
33-
$(pg_isolation_regress_installcheck) $(ISOLATIONCHECKS)
34-
35-
submake-isolation:
36-
$(MAKE) -C $(top_builddir)/src/test/isolation all
34+
installcheck: isolationcheck-install-force
3735

3836
isolationcheck: | submake-isolation temp-install
3937
$(MKDIR_P) isolation_output
@@ -42,4 +40,14 @@ isolationcheck: | submake-isolation temp-install
4240
--outputdir=isolation_output \
4341
$(ISOLATIONCHECKS)
4442

43+
isolationcheck-install-force: all | submake-isolation submake-pg_query_state temp-install
44+
$(pg_isolation_regress_installcheck) \
45+
$(ISOLATIONCHECKS)
46+
47+
submake-isolation:
48+
$(MAKE) -C $(top_builddir)/src/test/isolation all
49+
50+
submake-pg_query_state:
51+
$(MAKE) -C $(top_builddir)/contrib/pg_query_state
52+
4553
temp-install: EXTRA_INSTALL=contrib/pg_query_state

run_tests.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,17 +138,14 @@ fi
138138
# something's wrong, exit now!
139139
if [ $status -ne 0 ]; then cat /tmp/postgres.log; exit 1; fi
140140

141-
cd $CUSTOM_PG_SRC
142-
143141
# run regression tests
144142
export PG_REGRESS_DIFF_OPTS="-w -U3" # for alpine's diff (BusyBox)
145-
make -C $CUSTOM_PG_SRC/contrib/pg_query_state installcheck || status=$?
143+
cd $CUSTOM_PG_SRC/contrib/pg_query_state
144+
make installcheck || status=$?
146145

147146
# show diff if it exists
148147
if [ -f regression.diffs ]; then cat regression.diffs; fi
149148

150-
cd $CUSTOM_PG_SRC/contrib/pg_query_state
151-
152149
# run python tests
153150
set +x -e
154151
python3 -m venv /tmp/env && source /tmp/env/bin/activate &&

0 commit comments

Comments
 (0)
0