[PBCKP-236] draft, first-stage compatibility protocol impl with stubs

Ivan Lazarev · Ivan Lazarev · commit f5fde7ef8e1e · 2022-09-12T02:46:29.000+03:00
diff --git a/src/utils/file.c b/src/utils/file.c
@@ -281,7 +281,7 @@ fio_get_agent_version(int* protocol, char* payload_buf, size_t payload_buf_size)
 	IO_CHECK(fio_read_all(fio_stdin, &hdr, sizeof(hdr)), sizeof(hdr));
 	if (hdr.size > payload_buf_size)
 	{
-		elog(ERROR, "Bad protocol, insufficient payload_buf_size=%u", payload_buf_size);
+		elog(ERROR, "Bad protocol, insufficient payload_buf_size=%zu", payload_buf_size);
 	}
 
 	*protocol = hdr.arg;
@@ -3323,14 +3323,14 @@ fio_communicate(int in, int out)
 		  case FIO_AGENT_VERSION:
 			hdr.arg = AGENT_PROTOCOL_VERSION;
 			IO_CHECK(fio_write_all(out, &hdr, sizeof(hdr)), sizeof(hdr));
-			assert(false);
 			//TODO REVIEW XXX is it allowed by ANSI C to declare new scope inside???
 			{
 				size_t payload_size = prepare_remote_agent_compatibility_str(buf, buf_size);
 				IO_CHECK(fio_write_all(out, buf, payload_size), payload_size);
 				//TODO REVIEW XXX make INFO to LOG or VERBOSE
 				elog(INFO, "TODO REVIEW XXX sent agent compatibility\n %s", buf);
 			}
+			assert(false);
 			break;
 		  case FIO_STAT: /* Get information about file with specified path */
 			hdr.size = sizeof(st);

Original file line number	Diff line number	Diff line change
`@@ -281,7 +281,7 @@ fio_get_agent_version(int* protocol, char* payload_buf, size_t payload_buf_size)`
`281`	`281`	`IO_CHECK(fio_read_all(fio_stdin, &hdr, sizeof(hdr)), sizeof(hdr));`
`282`	`282`	`if (hdr.size > payload_buf_size)`
`283`	`283`	`{`
`284`		`- elog(ERROR, "Bad protocol, insufficient payload_buf_size=%u", payload_buf_size);`
	`284`	`+ elog(ERROR, "Bad protocol, insufficient payload_buf_size=%zu", payload_buf_size);`
`285`	`285`	`}`
`286`	`286`
`287`	`287`	`*protocol = hdr.arg;`
`@@ -3323,14 +3323,14 @@ fio_communicate(int in, int out)`
`3323`	`3323`	`case FIO_AGENT_VERSION:`
`3324`	`3324`	`hdr.arg = AGENT_PROTOCOL_VERSION;`
`3325`	`3325`	`IO_CHECK(fio_write_all(out, &hdr, sizeof(hdr)), sizeof(hdr));`
`3326`		`- assert(false);`
`3327`	`3326`	`//TODO REVIEW XXX is it allowed by ANSI C to declare new scope inside???`
`3328`	`3327`	`{`
`3329`	`3328`	`size_t payload_size = prepare_remote_agent_compatibility_str(buf, buf_size);`
`3330`	`3329`	`IO_CHECK(fio_write_all(out, buf, payload_size), payload_size);`
`3331`	`3330`	`//TODO REVIEW XXX make INFO to LOG or VERBOSE`
`3332`	`3331`	`elog(INFO, "TODO REVIEW XXX sent agent compatibility\n %s", buf);`
`3333`	`3332`	`}`
	`3333`	`+ assert(false);`
`3334`	`3334`	`break;`
`3335`	`3335`	`case FIO_STAT: /* Get information about file with specified path */`
`3336`	`3336`	`hdr.size = sizeof(st);`