tests: slow_start more robust behaviour

gsmolk · gsmolk · commit 4d8b6f50c9ae · 2019-01-14T19:58:15.000+03:00
diff --git a/tests/helpers/ptrack_helpers.py b/tests/helpers/ptrack_helpers.py
@@ -118,34 +118,28 @@ def __str__(self):
 def slow_start(self, replica=False):
 
     # wait for https://github.com/postgrespro/testgres/pull/50
-    # self.poll_query_until(
-    #    "postgres",
-    #    "SELECT not pg_is_in_recovery()",
-    #    raise_operational_error=False)
-
-    self.start()
+#    self.start()
+#    self.poll_query_until(
+#       "postgres",
+#       "SELECT not pg_is_in_recovery()",
+#       suppress={testgres.NodeConnection})
     if replica:
-        self.poll_query_until(
-            'postgres',
-            'SELECT pg_is_in_recovery()')
+        query = 'SELECT not pg_is_in_recovery()'
     else:
-        while True:
-            try:
-                self.poll_query_until(
-                    'postgres',
-                    'SELECT not pg_is_in_recovery()')
-                break
-            except Exception as e:
-                continue
+        query = 'SELECT pg_is_in_recovery()'
 
-#        while True:
-#            try:
-#                self.poll_query_until(
-#                    "postgres",
-#                    "SELECT pg_is_in_recovery()")
-#                break
-#            except ProbackupException as e:
-#                continue
+    self.start()
+    while True:
+        try:
+            self.safe_psql(
+                'postgres',
+                query)
+            break
+        except testgres.QueryException as e:
+            if 'database system is starting up' in e[0]:
+                continue
+            else:
+                raise e
 
 
 class ProbackupTest(object):
