A couple of sanity checks.

arssher · arssher · commit dbf8262dca5e · 2019-03-12T09:28:31.000+03:00
One of them is pretty ugly -- we are checking out pathman_config each time
during create_single_range_partition_internal.

Also invalidate prel cache after manual add_to_pathman_config, just in case.
diff --git a/src/partition_creation.c b/src/partition_creation.c
@@ -112,6 +112,23 @@ create_single_range_partition_internal(Oid parent_relid,
 	init_callback_params	callback_params;
 	List				   *trigger_columns = NIL;
 	Node				   *expr;
+	Datum		values[Natts_pathman_config];
+	bool		isnull[Natts_pathman_config];
+
+
+	/*
+	 * Sanity check. Probably needed only if some absurd init_callback
+	 * decides to drop the table while we are creating partitions.
+	 * It seems much better to use prel cache here, but this doesn't work
+	 * because it regards tables with no partitions as not partitioned at all
+	 * (build_pathman_relation_info returns NULL), and if I comment out that,
+	 * tests fail for not immediately obvious reasons. Don't want to dig
+	 * into this now.
+	 */
+	if (!pathman_config_contains_relation(parent_relid, values, isnull, NULL, NULL))
+	{
+		elog(ERROR, "Can't create range partition: relid %u doesn't exist or not partitioned", parent_relid);
+	}
 
 	/* Generate a name if asked to */
 	if (!partition_rv)
diff --git a/src/pl_funcs.c b/src/pl_funcs.c
@@ -252,6 +252,11 @@ show_cache_stats_internal(PG_FUNCTION_ARGS)
 
 		funccxt = SRF_FIRSTCALL_INIT();
 
+		if (!TopPathmanContext)
+		{
+			elog(ERROR, "pg_pathman's memory contexts are not initialized yet");
+		}
+
 		old_mcxt = MemoryContextSwitchTo(funccxt->multi_call_memory_ctx);
 
 		usercxt = (show_cache_stats_cxt *) palloc(sizeof(show_cache_stats_cxt));
@@ -893,6 +898,8 @@ add_to_pathman_config(PG_FUNCTION_ARGS)
 		}
 	}
 
+	CacheInvalidateRelcacheByRelid(relid);
+
 	PG_RETURN_BOOL(true);
 }
 
