Purge potentially created bounds cache entries if build_pathman_relation_info failed.

arssher · arssher · commit 079797e0d5ef · 2019-04-11T12:57:24.000+03:00
Otherwise they might contain obsolete data, e.g.
 - create range partitioned table T with a couple of partitions
 - make pathman forget about it
 - create another table P inherited from previously partitioned one, but with no
   pathman constraints
 - attempt to add_to_pathman_config T as range partitioned table
     it will fail as P has no constraint, but might register other partitions in
     bounds cache
 - now add_to_pathman_config T as hash partitioned table will fail in attempt
   to use this cache (part_idx not initialized)
diff --git a/src/relation_info.c b/src/relation_info.c
@@ -408,7 +408,7 @@ build_pathman_relation_info(Oid relid, Datum *values)
 	prel->fresh		= true;
 	prel->mcxt		= prel_mcxt;
 
-	/* Memory leak protection */
+	/* Memory leak and cache protection */
 	PG_TRY();
 	{
 		MemoryContext			old_mcxt;
@@ -496,6 +496,32 @@ build_pathman_relation_info(Oid relid, Datum *values)
 	}
 	PG_CATCH();
 	{
+		/*
+		 * If we managed to create some children but failed later, bounds
+		 * cache now might have obsolete data for something that probably is
+		 * not a partitioned table at all. Remove it.
+		 */
+		if (prel->children != NULL)
+		{
+			uint32 i;
+
+			for (i = 0; i < PrelChildrenCount(prel); i++)
+			{
+				Oid child;
+
+				/*
+				 * We rely on children and ranges array allocated with 0s, not
+				 * random data
+				 */
+				if (prel->parttype == PT_HASH)
+					child = prel->children[i];
+				else if (prel->parttype == PT_RANGE)
+					child = prel->ranges[i].child_oid;
+
+				forget_bounds_of_partition(child);
+			}
+		}
+
 		/* Free this entry */
 		free_pathman_relation_info(prel);
 
