Disallow AQO to write into the ML-tables if can be detected that

danolivo · danolivo · commit 91bed68cc58c · 2021-07-05T16:46:04.000+03:00
the query must be read-only (by the flag XactReadOnly).
diff --git a/storage.c b/storage.c
@@ -125,6 +125,10 @@ update_query(int qhash, int fhash,
 	ScanKeyData key;
 	SnapshotData snap;
 
+	/* Couldn't allow to write if xact must be read-only. */
+	if (XactReadOnly)
+		return false;
+
 	reloid = RelnameGetRelid("aqo_queries_query_hash_idx");
 	if (!OidIsValid(reloid))
 	{
@@ -228,6 +232,10 @@ add_query_text(int qhash)
 	values[0] = Int32GetDatum(qhash);
 	values[1] = CStringGetTextDatum(query_text);
 
+	/* Couldn't allow to write if xact must be read-only. */
+	if (XactReadOnly)
+		return false;
+
 	reloid = RelnameGetRelid("aqo_query_texts_query_hash_idx");
 	if (!OidIsValid(reloid))
 	{
@@ -374,6 +382,10 @@ update_fss(int fhash, int fsshash, int nrows, int ncols,
 	ScanKeyData	key[2];
 	bool result = true;
 
+	/* Couldn't allow to write if xact must be read-only. */
+	if (XactReadOnly)
+		return false;
+
 	reloid = RelnameGetRelid("aqo_fss_access_idx");
 	if (!OidIsValid(reloid))
 	{
@@ -563,6 +575,10 @@ update_aqo_stat(int qhash, QueryStat *stat)
 	IndexScanDesc scan;
 	ScanKeyData	key;
 
+	/* Couldn't allow to write if xact must be read-only. */
+	if (XactReadOnly)
+		return;
+
 	reloid = RelnameGetRelid("aqo_query_stat_idx");
 	if (!OidIsValid(reloid))
 	{
