8000 pg_dump: Fix object-type sort priority for large objects. · postgres/postgres@fb6c860 · GitHub
[go: up one dir, main page]
Skip to content

Commit fb6c860

Browse files
nathan-bossartnathan-bossart
committed
pg_dump: Fix object-type sort priority for large objects.
Commit a45c78e moved large object metadata from SECTION_PRE_DATA to SECTION_DATA but neglected to move PRIO_LARGE_OBJECT in dbObjectTypePriorities accordingly. While this hasn't produced any known live bugs, it causes problems for a proposed patch that optimizes upgrades with many large objects. Fixing the priority might also make the topological sort step marginally faster by reducing the number of ordering violations that have to be fixed. Reviewed-by: Nitin Motiani <nitinmotiani@google.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathan Discussion: https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathan Backpatch-through: 17
1 parent b41c430 commit fb6c860

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/bin/pg_dump/pg_dump_sort.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ enum dbObjectTypePriorities
7676
PRIO_TABLE_ATTACH,
7777
PRIO_DUMMY_TYPE,
7878
PRIO_ATTRDEF,
79-
PRIO_LARGE_OBJECT,
8079
PRIO_PRE_DATA_BOUNDARY, /* boundary! */
8180
PRIO_TABLE_DATA,
8281
PRIO_SEQUENCE_SET,
82+
PRIO_LARGE_OBJECT,
8383
PRIO_LARGE_OBJECT_DATA,
8484
PRIO_STATISTICS_DATA_DATA,
8585
PRIO_POST_DATA_BOUNDARY, /* boundary! */

0 commit comments

Comments
 (0)
0